Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix alignment for 'Add new server' button #541

Merged
merged 1 commit into from
May 31, 2017

Conversation

yuya-oc
Copy link
Contributor

@yuya-oc yuya-oc commented May 30, 2017

Before submitting, please confirm you've

Please provide the following information:

Summary
Fix alignment for 'Add new server' button. (+)

v3.7.0 on Mac:
v3 7 0

PR on Mac:
proposal

It looks Button component makes the alignment difficult. So I stopped using Button. And '+' is a plain text font, so I think it's difficult to layout at "complete center".
Please see the actual alignment.

Issue link
#540 (comment)

Test Cases

  1. Add two servers at least.
  2. Open the main page.
  3. See tab bar.
  4. The '+' button should work as expected.

Additional Notes
https://circleci.com/gh/yuya-oc/desktop/264#artifacts

@yuya-oc yuya-oc added this to the v3.8.0 milestone May 30, 2017
@jasonblais
Copy link
Contributor

jasonblais commented May 30, 2017

Thanks @yuya-oc!

It's slightly off-center for me on Windows 10 Home

image

EDIT:

And '+' is a plain text font, so I think it's difficult to layout at "complete center".

It's okay if it's not completely centered, but it would be good to move it a couple of mm down on Windows. It won't be as noticeable anymore at that point.

@yuya-oc
Copy link
Contributor Author

yuya-oc commented May 30, 2017

Not necessary. Screenshots I posted are the result.

I think the font itself for '+' is off-center in English lettering. For example, '+' is slightly off-center on pre-release server (Chrome, Windows 10).

plus-font

@jasonblais
Copy link
Contributor

The "+" sign next to the tab bar is noticeably off-center though -- it's almost centered on the channel sidebar

@yuya-oc
Copy link
Contributor Author

yuya-oc commented May 30, 2017

https://circleci.com/gh/yuya-oc/desktop/265#artifacts

I used the glyphicon of bootstrap. It's an icon, so probably it would be center-aligned. How about this?

glyphicon-plus

@jasonblais
Copy link
Contributor

Looks great, thanks @yuya-oc!

image

@yuya-oc
Copy link
Contributor Author

yuya-oc commented May 31, 2017

Thanks for feedback!

@yuya-oc yuya-oc merged commit 446af5e into mattermost:master May 31, 2017
@yuya-oc yuya-oc deleted the fix-add-button-align branch May 31, 2017 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants