Upgrade to Electron v3 #892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When there is navigation with #btnClose, all APIs would fail. So such tests are marked as "skipped".
yuya-oc
added
All Platforms
3 tasks
This was referenced Nov 26, 2018
|
Tested on macOS 10.14.1. Deep linking is working for me. |
|
Bumped to v3.0.10 and changed version restriction due to #903 (review) |
crspeller
approved these changes
Dec 3, 2018
|
@yuya-oc I have good news. I tested your patch on Appveyor and the build succeeed
We are ready to de-yarn-ise (aka switch back to npm) the app then :) |
wget
approved these changes
Dec 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting, please confirm you've
npm run lint:jsfor proper code formattingPlease provide the following information:
Summary
Upgrade Electron to v3.0.9.
Sadly I could not fix all of tests now. They passed on my PC, but it seems that the app can't start randomly in CircleCI (or docker) environment.
Issue link
N/A
Test Cases
A. General usecases should work.
B. Deep linking should work. (There is a breaking change in Electron v3)
Additional Notes
https://circleci.com/gh/yuya-oc/desktop/1137#artifacts