Upgrade babel, webpack and storybook stack #903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wget
requested changes
Dec 1, 2018
crspeller
approved these changes
Dec 3, 2018
yuya-oc
force-pushed
the
upgrade-build-tools
branch
from
a67428b
to
fa272ed
Compare
|
Rebased to solve conflicts. |
wget
approved these changes
Dec 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting, please confirm you've
npm run lint:jsfor proper code formattingPlease provide the following information:
Summary
Upgrade babel, webpack and storybook stack.
This is a part of #898 in the release process. Those tools have major update, so there are some changes in config files. This PR eventually solves #901 and #902.
Issue link
#898, #901 , #902
Test Cases
These cases are checked on CircleCI.
npm run package:(windows|mac|linux)npm run storybookAdditional Notes
https://circleci.com/gh/yuya-oc/desktop/1172#artifacts