Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix an issue for the field size limiting #41

Merged
merged 1 commit into from
Aug 11, 2023
Merged

Conversation

isacikgoz
Copy link
Member

Summary

@wiggin77 It seems like copy didn't work out because the len was 0 . I updated the logic and added a unit test this time. I should've added the unit test before merging the other PR, I'm sorry this bothered you quite a lot.

@isacikgoz isacikgoz added the 2: Dev Review Requires review by a core committer label Aug 11, 2023
@github-actions
Copy link

Unit Test Results

69 tests  +1   69 ✔️ +1   24s ⏱️ ±0s
10 suites ±0     0 💤 ±0 
  1 files   ±0     0 ±0 

Results for commit a4fd202. ± Comparison against base commit a5b7201.

Copy link
Member

@wiggin77 wiggin77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should have caught that.

@wiggin77 wiggin77 added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Aug 11, 2023
@wiggin77 wiggin77 merged commit 918322d into master Aug 11, 2023
2 checks passed
@wiggin77 wiggin77 deleted the bugfix-limitation branch August 11, 2023 18:41
@wiggin77
Copy link
Member

@isacikgoz version v2.0.18 is published. .17 was deleted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants