Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MM-16712 Allow specifying number of minio and mysql replicas in ClusterInstallation spec #50

Merged
merged 3 commits into from
Jul 8, 2019

Conversation

jwilander
Copy link
Member

@@ -87,6 +87,6 @@ spec:
serviceAccountName: minio-operator-sa
containers:
- name: minio-operator
image: minio/k8s-operator:latest
image: mattermost/minio-operator
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pointing at our Docker image to support standalone Minio until minio/operator#23 is accepted and also until the Minio operator is tagged so we don't have to worry about breaking changes

@gabrieljackson
Copy link
Collaborator

Will wait to review until tests pass in case a change is required.

@jwilander
Copy link
Member Author

@cpanato I'm unsure if the tests are failing because of my changes or if the CI machine is just running out of memory, any idea?

@cpanato
Copy link
Contributor

cpanato commented Jul 6, 2019

@jwilander checking

@cpanato
Copy link
Contributor

cpanato commented Jul 6, 2019

@jwilander the issue is in the tests you are waiting for 1 deployment for minio and mysql but both have 4 pods

•100% ➜ kubectl get pod -n mattermost-operator
NAME                                  READY   STATUS     RESTARTS   AGE
mattermost-operator-8dcb8db6f-hlh9x   1/1     Running    0          7m48s
test-mm-56965bf9cf-nskrq              1/1     Running    0          7m32s
test-mm-minio-0                       1/1     Running    0          7m33s
test-mm-minio-1                       1/1     Running    0          7m17s
test-mm-minio-2                       1/1     Running    0          7m4s
test-mm-minio-3                       1/1     Running    0          6m24s
test-mm-mysql-mysql-0                 4/4     Running    0          7m31s
test-mm-mysql-mysql-1                 4/4     Running    0          5m58s
test-mm-mysql-mysql-2                 4/4     Running    0          3m33s
test-mm-mysql-mysql-3                 0/4     Init:1/2   0          66s

@cpanato
Copy link
Contributor

cpanato commented Jul 6, 2019

also in the test you are waiting for deployment and both minio and mysql are not deployments they are statefullsets :)

Copy link
Contributor

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only thing I don't like much is the fork of minio, if that takes longer we will need to maintain our custom fork :/

Copy link
Collaborator

@gabrieljackson gabrieljackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

pkg/apis/mattermost/v1alpha1/clusterinstallation_types.go Outdated Show resolved Hide resolved
Co-Authored-By: Gabe Jackson <gabe@coffeepowered.co>
@jwilander
Copy link
Member Author

Thanks for the test help @cpanato !

@jwilander jwilander merged commit b285b86 into master Jul 8, 2019
@jwilander jwilander deleted the mm-16712 branch July 8, 2019 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants