-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MM-16712 Allow specifying number of minio and mysql replicas in ClusterInstallation spec #50
Conversation
@@ -87,6 +87,6 @@ spec: | |||
serviceAccountName: minio-operator-sa | |||
containers: | |||
- name: minio-operator | |||
image: minio/k8s-operator:latest | |||
image: mattermost/minio-operator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pointing at our Docker image to support standalone Minio until minio/operator#23 is accepted and also until the Minio operator is tagged so we don't have to worry about breaking changes
Will wait to review until tests pass in case a change is required. |
@cpanato I'm unsure if the tests are failing because of my changes or if the CI machine is just running out of memory, any idea? |
@jwilander checking |
@jwilander the issue is in the tests you are waiting for 1 deployment for minio and mysql but both have 4 pods
|
also in the test you are waiting for deployment and both minio and mysql are not deployments they are statefullsets :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only thing I don't like much is the fork of minio, if that takes longer we will need to maintain our custom fork :/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Co-Authored-By: Gabe Jackson <gabe@coffeepowered.co>
Thanks for the test help @cpanato ! |
https://mattermost.atlassian.net/browse/MM-16712