Disable CGO for all builds #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DHaussermann Please test if this resolves the issue |
|
On my local machine the bundle is 4kb bigger. 18434400 (new) vs. 18480021(old) |
hanzei
added
2: Dev Review
mickmister
approved these changes
Apr 6, 2022
catalintomai
approved these changes
Apr 6, 2022
DHaussermann
approved these changes
Apr 6, 2022
DHaussermann
added
4: Reviews Complete
This was referenced Nov 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The cloud servers complain about a missing symbol:
error relocating plugins/com.mattermost.apps/server/dist/plugin-linux-amd64: __fprintf_chk: symbol not foundBy static linking the binary we not longer rely on a DL to be there.
Ticket Link
None?