Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The user is getting multiple notifications in the channel or DM/GM on MM for a event on Jira when duplicate subscriptions are created. #1011

Closed
arush-vashishtha opened this issue Dec 27, 2023 · 2 comments · Fixed by #1103
Closed

The user is getting multiple notifications in the channel or DM/GM on MM for a event on Jira when duplicate subscriptions are created. #1011

arush-vashishtha opened this issue Dec 27, 2023 · 2 comments · Fixed by #1103
Labels
Type/Bug Something isn't working
Milestone
v4.2.0

Comments

@arush-vashishtha
Copy link

Summary

The user can create duplicate subscription for an existing subscription and it results in generating same notification the number of times the subscription is duplicated.

Steps to reproduce

  1. Create a subscription using the /jira subscribe edit slash command in any desired channel or DM/GM on MM.
  2. Create a duplicate subscription for the above added subscription using the /jira subscribe edit slash command in the same desired channel or DM/GM on MM.
  3. Create the event on Jira for which the above subscriptions were created in the desired channel or DM/GM on MM.

Expected behavior

The user should get only one notification for the event in the desired channel or DM/GM on MM.

Actual behavior

The user is getting N number of notifications for the event in the desired channel or DM/GM where N is the number of subscriptions created for that event on MM.

Screenshots

image
@arush-vashishtha arush-vashishtha mentioned this issue Dec 27, 2023
Merged
@mkddostro
Copy link

Not sure if this is related but after issues with the settings (in Jira, webhook and app permissions) I set up a new app in Jira and deleted the old one. Since then I am receiving duplicate notifications for every action I am subscribed to.

@Kshitij-Katiyar Kshitij-Katiyar added the Type/Bug Something isn't working label May 8, 2024
@raghavaggarwal2308
Copy link
Contributor

Not sure if this is related but after issues with the settings (in Jira, webhook and app permissions) I set up a new app in Jira and deleted the old one. Since then I am receiving duplicate notifications for every action I am subscribed to.

@mkddostro Did create new subscriptions after setting up the new app?

raghavaggarwal2308 added a commit that referenced this issue Jul 16, 2024
@raghavaggarwal2308
[GH-1011] Added conditional to avoid posting multiple notifications i…
71fceb9 
…n case of duplicate subscriptions.
@raghavaggarwal2308 raghavaggarwal2308 mentioned this issue Jul 16, 2024
Merged
@raghavaggarwal2308 raghavaggarwal2308 added this to the v4.2.0 milestone Jul 17, 2024
@raghavaggarwal2308 raghavaggarwal2308 removed this from the v4.2.0 milestone Jul 31, 2024
raghavaggarwal2308 added a commit that referenced this issue Sep 6, 2024
@raghavaggarwal2308 @Kshitij-Katiyar
[GH-1011] Added conditional to avoid posting multiple notifications i…
5b762da 
…n case of duplicate subscriptions (#1103)

* [GH-1011] Added conditional to avoid posting multiple notifications in case of duplicate subscriptions.

* [MM-1011]: used map in place of traversing array for getChannelsSubscribed

* [MM-1011]: Update the map on every iteration

---------

Co-authored-by: kshitij katiyar <kshitij.katiyar@brightscout.com>
@raghavaggarwal2308 raghavaggarwal2308 added this to the v4.2.0 milestone Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type/Bug Something isn't working
Projects
None yet
Milestone
v4.2.0
4 participants
@mkddostro @raghavaggarwal2308 @Kshitij-Katiyar @arush-vashishtha