Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate tooltips of 'components/advanced_create_post/priority_labels' to WithTooltip #27148

Closed
mattermod opened this issue May 24, 2024 · 0 comments · Fixed by #27163
Closed
Assignees
Labels
Difficulty/1:Easy Easy ticket Help Wanted Community help wanted Tech/ReactJS Web app

Comments

@mattermod
Copy link
Contributor

Introduction

The purpose of this ticket is to eliminate the usage of OverlayTrigger of ‘components/overlay_trigger’ & Tooltip of ‘components/tooltip’ in the above mentioned file and replace the tooltip with component WithTooltip from ‘components/with_tooltip’. For reference, you can follow these PRs -

Before you start:

  • Assignment Confirmation: Comment on this ticket to express your interest in owning it. This will help prevent task duplication.
  • Environment Setup: Ensure your development environment is up and running. Follow the setup guide https://developers.mattermost.com/contribute/developer-setup
  • Analyse: Navigate to the file referenced in this ticket and examine its usage within Mattermost. Capture screenshots of where and how the tooltip is used.
  • Best Practices: Familiarize yourself with the best practices for contributing to the Mattermost https://developers.mattermost.com/contribute/why-contribute

Checklist Before PR Submission:

  • Screenshots for Comparison: Capture screenshots of the places where you replaced tooltips to WithTooltip component. These screenshots will allow for a quick visual comparison within the PR, helping identify any unintended UI changes. Remember to include the screenshot you took earlier for a before-and-after comparison. Screenshots also make it easier for QA to locate and review the changes made to components.
  • PR Title Format: Write the title of your PR using the following format: '[MM-jiraTicketNumber] Write the ticket title here'.
  • CI Checks: Ensure all Continuous Integration checks have passed successfully. The review process can only commence when all CI checks are green.

If you're interested please comment here and come join our "Contributors" community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our "Developers" community channel.

New contributors please see our Developer's Guide.

JIRA: https://mattermost.atlassian.net/browse/MM-58404

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Difficulty/1:Easy Easy ticket Help Wanted Community help wanted Tech/ReactJS Web app
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants