Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

Copy over platform README and add PR template #3

Merged
merged 3 commits into from
Sep 7, 2017
Merged

Conversation

jwilander
Copy link
Member

@jwilander jwilander commented Sep 7, 2017

To be used temporarily until we have a custom readme for the webapp. Also added a PR template.

@jwilander jwilander added the 2: Dev Review Requires review by a core commiter label Sep 7, 2017
@jwilander jwilander changed the title Copy over platform README Copy over platform README and add PR template Sep 7, 2017
@jasonblais jasonblais mentioned this pull request Sep 7, 2017
Copy link
Contributor

@enahum enahum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

non blocking but would be nice

PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
@jwilander jwilander removed the request for review from grundleborg September 7, 2017 12:26
Copy link
Contributor

@grundleborg grundleborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but who has the power to merge in this repo? I certainly don't.

Mattermost is an open source, self-hosted Slack-alternative from [https://mattermost.org](https://mattermost.org).

It's written in Golang and React and runs as a single Linux binary with MySQL or Postgres. Every month on the 16th [a new compiled version is released under an MIT license](https://www.mattermost.org/download/).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0/5, propose a note along the lines of

This project hosts the webapp client code. The server code is hosted at [/mattermost-server](https://github.com/mattermost/mattermost-server).

@@ -1,3 +1,4 @@
dist
.yarninstall
node_modules
*.swp
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even if not in this PR - Probably yarn-error.logas well

@crspeller crspeller merged commit d00431b into master Sep 7, 2017
@crspeller crspeller deleted the readme branch September 7, 2017 13:53
@lindalumitchell lindalumitchell added the Tests/Not Needed Does not require new release tests label Sep 28, 2017
@jasonblais jasonblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Oct 2, 2017
enahum pushed a commit that referenced this pull request Feb 16, 2018
* MM-8589: expunge global mm_config from navbar component

* MM-8589: expunge global mm_config from file_upload and related components

* MM-8589: expunge global mm_(config|license) from the tutorial component

* MM-8589: expunge global mm_config from channel view component

* MM-8589: expunge global mm_config from DoVerifyEmail component

* MM-8589: use the get(Config|License) selector

* MM-8589: expunge unnecessary ownProps
lieut-data added a commit that referenced this pull request Feb 28, 2018
) (#865)

* MM-9635: expunge global mm_(license|config) from channel intro message component

* MM-9635: pass isLicensed to isChannelAdmin

* MM-9635: remove unused getWebsocketPort

* MM-9635: pass enableEmailBatching to getEmailInterval

* MM-9635: pass license and config to canDownloadFiles

* MM-9635: pass license and config to checkIfMFARequired
lieut-data pushed a commit that referenced this pull request Nov 23, 2018
… settings and remove header and footer (#1971)

* MM-12400: Custom terms of service feature Phase 2
- Remove Footer text and title
- Add reacceptance interval setting in the Admin Console
- Update names as used in the redux PR
- Remove redux actions to use BindActionCreators
- Update styles
- Update tests
- Update reacceptance flag

* MM-12413 (#3)

* Remove fixed footer
* Finish footer CSS changes
* MM-12411 Update help texts
* MM-12415 Remove Beta Labels
* Fix check-style

* Update terms of service page background colors
Add colons in Admin Console settings

* MM-12414 Remove redux hack

* Fix check-style

* Update styles

* Update tests

* Fix css height

* review feedback
@JtheBAB JtheBAB mentioned this pull request Jan 15, 2019
9 tasks
@hanzei hanzei added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter labels Mar 22, 2019
chetanyakan referenced this pull request in brightscout-alpha/mattermost-webapp May 14, 2019
Adds a WebRTC button on channel headers.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation Tests/Not Needed Does not require new release tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants