Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

[MM-27231]: cypress test for MM-T1837 #6676

Merged
merged 6 commits into from
Oct 13, 2020
Merged

[MM-27231]: cypress test for MM-T1837 #6676

merged 6 commits into from
Oct 13, 2020

Conversation

ashishbhate
Copy link
Contributor

Summary

  • Automate MM-T1837: Bot DM channels display a normal Header

Ticket Link

@ashishbhate ashishbhate added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels Oct 7, 2020
@ashishbhate
Copy link
Contributor Author

AFAIK, a bot a from a plugin is the same as a "normal" bot, so there's only one test here.

@josephbaylon
Copy link
Contributor

@ashishbhate I think step 2 refers to uploading/enabling a plugin and checking if the bot from that plugin also works. It may have the same expectation but the creation flow is a bit different, e.g.

        // # Upload and enable "matterpoll" plugin
        cy.apiUploadPlugin('com.github.matterpoll.matterpoll.tar.gz').then(() => {
            cy.apiEnablePluginById('com.github.matterpoll.matterpoll');
        });

then check the DM for @matterpoll

@ashishbhate
Copy link
Contributor Author

@josephbaylon updated with a test for a bot from a plugin.

Copy link
Contributor

@josephbaylon josephbaylon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just minor title changes to match TM4J. Thanks @ashishbhate !!

e2e/cypress/integration/messaging/header_spec.js Outdated Show resolved Hide resolved
e2e/cypress/integration/messaging/header_spec.js Outdated Show resolved Hide resolved
@esethna esethna requested review from nevyangelova and removed request for calebroseland October 8, 2020 20:03
Co-authored-by: Joseph Baylon <joseph.baylon@mattermost.com>
@ashishbhate
Copy link
Contributor Author

/update-branch

Copy link

@ogi-m ogi-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ogi-m ogi-m added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels Oct 13, 2020
@josephbaylon josephbaylon merged commit dd765cd into master Oct 13, 2020
@josephbaylon josephbaylon deleted the mm-27231-T1837 branch October 13, 2020 18:12
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Oct 13, 2020
Tak-Iwamoto pushed a commit to Tak-Iwamoto/mattermost-webapp that referenced this pull request Oct 14, 2020
…o MM-20457

* 'master' of github.com:Tak-Iwamoto/mattermost-webapp: (87 commits)
  MM-T644 Integrations display on team where they were created (mattermost#6752)
  [MM-20478] Migrate post_header module to TypeScript (mattermost#6631)
  [MM-20599] Migrated select_team component to Typescript (mattermost#6574)
  MM-20554 Migrate 'components/delete_post_modal' module and associated tests to TypeScript (mattermost#6656)
  [MM-24436]- Add a threshold from bottom for new messages toast (mattermost#5828)
  [MM-20489] Migrate failed_post_options and its tests to typescript (mattermost#6717)
  [MM-28063] Cloud Telemetry - Admin Console (mattermost#6762)
  [MM-29559][MM-29558] Company Info Fixes (mattermost#6764)
  [MM-29557] [MM-29590] Update subscription when purchase modal closes (mattermost#6765)
  [MM-29615] Fixed subscription page so it doesn't load until subscription info is loaded (mattermost#6766)
  [MM-28064] Add telemetry in various places around cloud message banners (mattermost#6763)
  migrate changeCSS function CSS variable for mobile CSS .tutorial-steps__container selector. (mattermost#6743)
  [MM-27231]: cypress test for MM-T1837 (mattermost#6676)
  [MM-28062] Add telemetry for in-app purchase flow (mattermost#6760)
  MM-27454 - Contact Us and Billing Documentation Links (mattermost#6731)
  [MM-20514] Migrates components/password reset send link to typescript (mattermost#6584)
  Cloud Billing polish Soft GA (mattermost#6740)
  [MM-28221] Payment Info Edit/View (mattermost#6709)
  MM-T636 Description field for incoming and outgoing webhooks can hold 500 characters (mattermost#6682)
  Translations update from Weblate (mattermost#6748)
  ...
jfrerich pushed a commit that referenced this pull request Oct 23, 2020
* [MM-27231]: cypress test for MM-T1837

* fix comment format

* Add tests for plugin bots

* clean up after test

* Apply suggestions from code review

Co-authored-by: Joseph Baylon <joseph.baylon@mattermost.com>

Co-authored-by: Joseph Baylon <joseph.baylon@mattermost.com>
Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
calebroseland pushed a commit that referenced this pull request Oct 27, 2020
* [MM-27231]: cypress test for MM-T1837

* fix comment format

* Add tests for plugin bots

* clean up after test

* Apply suggestions from code review

Co-authored-by: Joseph Baylon <joseph.baylon@mattermost.com>

Co-authored-by: Joseph Baylon <joseph.baylon@mattermost.com>
Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation
Projects
None yet
6 participants