This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
[MM-27231]: cypress test for MM-T1837 #6676
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AFAIK, a bot a from a plugin is the same as a "normal" bot, so there's only one test here. |
@ashishbhate I think step 2 refers to uploading/enabling a plugin and checking if the bot from that plugin also works. It may have the same expectation but the creation flow is a bit different, e.g.
then check the DM for |
@josephbaylon updated with a test for a bot from a plugin. |
josephbaylon
approved these changes
Oct 8, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just minor title changes to match TM4J. Thanks @ashishbhate !!
nevyangelova
approved these changes
Oct 9, 2020
Co-authored-by: Joseph Baylon <joseph.baylon@mattermost.com>
/update-branch |
ogi-m
approved these changes
Oct 13, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Tak-Iwamoto
pushed a commit
to Tak-Iwamoto/mattermost-webapp
that referenced
this pull request
Oct 14, 2020
…o MM-20457 * 'master' of github.com:Tak-Iwamoto/mattermost-webapp: (87 commits) MM-T644 Integrations display on team where they were created (mattermost#6752) [MM-20478] Migrate post_header module to TypeScript (mattermost#6631) [MM-20599] Migrated select_team component to Typescript (mattermost#6574) MM-20554 Migrate 'components/delete_post_modal' module and associated tests to TypeScript (mattermost#6656) [MM-24436]- Add a threshold from bottom for new messages toast (mattermost#5828) [MM-20489] Migrate failed_post_options and its tests to typescript (mattermost#6717) [MM-28063] Cloud Telemetry - Admin Console (mattermost#6762) [MM-29559][MM-29558] Company Info Fixes (mattermost#6764) [MM-29557] [MM-29590] Update subscription when purchase modal closes (mattermost#6765) [MM-29615] Fixed subscription page so it doesn't load until subscription info is loaded (mattermost#6766) [MM-28064] Add telemetry in various places around cloud message banners (mattermost#6763) migrate changeCSS function CSS variable for mobile CSS .tutorial-steps__container selector. (mattermost#6743) [MM-27231]: cypress test for MM-T1837 (mattermost#6676) [MM-28062] Add telemetry for in-app purchase flow (mattermost#6760) MM-27454 - Contact Us and Billing Documentation Links (mattermost#6731) [MM-20514] Migrates components/password reset send link to typescript (mattermost#6584) Cloud Billing polish Soft GA (mattermost#6740) [MM-28221] Payment Info Edit/View (mattermost#6709) MM-T636 Description field for incoming and outgoing webhooks can hold 500 characters (mattermost#6682) Translations update from Weblate (mattermost#6748) ...
jfrerich
pushed a commit
that referenced
this pull request
Oct 23, 2020
* [MM-27231]: cypress test for MM-T1837 * fix comment format * Add tests for plugin bots * clean up after test * Apply suggestions from code review Co-authored-by: Joseph Baylon <joseph.baylon@mattermost.com> Co-authored-by: Joseph Baylon <joseph.baylon@mattermost.com> Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
calebroseland
pushed a commit
that referenced
this pull request
Oct 27, 2020
* [MM-27231]: cypress test for MM-T1837 * fix comment format * Add tests for plugin bots * clean up after test * Apply suggestions from code review Co-authored-by: Joseph Baylon <joseph.baylon@mattermost.com> Co-authored-by: Joseph Baylon <joseph.baylon@mattermost.com> Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
4: Reviews Complete
All reviewers have approved the pull request
Changelog/Not Needed
Does not require a changelog entry
Docs/Not Needed
Does not require documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ticket Link