Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

MM-T636 Description field for incoming and outgoing webhooks can hold 500 characters #6682

Merged
merged 7 commits into from
Oct 13, 2020
Merged

MM-T636 Description field for incoming and outgoing webhooks can hold 500 characters #6682

merged 7 commits into from
Oct 13, 2020

Conversation

MikeworX
Copy link
Contributor

@MikeworX MikeworX commented Oct 7, 2020

This PR validates that the description field for both incoming and outgoing webhooks can only hold 500 characters.

The webhook add page is loaded, then 503 characters are typed into the description field. The character count in the field is then asserted to be 500 and not 503.

Screen Shot 2020-10-07 at 10 21 18 AM

vercel
TM4J

@mattermod
Copy link
Contributor

Hello @MikeworX,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@jasonblais jasonblais added 2: Dev Review Requires review by a core commiter hacktoberfest-accepted labels Oct 7, 2020
@hanzei hanzei added the 3: QA Review Requires review by a QA tester label Oct 8, 2020
srkgupta
srkgupta suggested changes Oct 8, 2020
View reviewed changes
Copy link
Contributor

@srkgupta srkgupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @MikeworX

Please find my comments. Also, please try to make the filename simple and short. Adding the assertions as filename does not looks good as it makes it lengthy. You can make it short like:
description_length_check_spec.js

...webhook/description_field_for_incoming_and_outgoing_webhooks_can_hold_500_characters_spec.js Outdated Show resolved Hide resolved
...webhook/description_field_for_incoming_and_outgoing_webhooks_can_hold_500_characters_spec.js Outdated Show resolved Hide resolved
...webhook/description_field_for_incoming_and_outgoing_webhooks_can_hold_500_characters_spec.js Outdated Show resolved Hide resolved
...webhook/description_field_for_incoming_and_outgoing_webhooks_can_hold_500_characters_spec.js Outdated Show resolved Hide resolved
@MikeworX MikeworX requested a review from srkgupta October 9, 2020 15:54
saturninoabril
saturninoabril suggested changes Oct 11, 2020
View reviewed changes
Copy link
Member

@saturninoabril saturninoabril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MikeworX! Please see comments.

e2e/cypress/integration/integrations/incoming_webhook/description_length_check_spec.js Outdated Show resolved Hide resolved
e2e/cypress/integration/integrations/incoming_webhook/description_length_check_spec.js Outdated Show resolved Hide resolved
e2e/cypress/integration/integrations/incoming_webhook/description_length_check_spec.js Outdated Show resolved Hide resolved
...webhook/description_field_for_incoming_and_outgoing_webhooks_can_hold_500_characters_spec.js Outdated Show resolved Hide resolved
saturninoabril
saturninoabril approved these changes Oct 12, 2020
View reviewed changes
Copy link
Member

@saturninoabril saturninoabril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MikeworX Thanks for updating. Looks good to me! I left last comment which I missed during the previous review.

e2e/cypress/integration/integrations/incoming_webhook/description_length_check_spec.js Outdated Show resolved Hide resolved
@saturninoabril saturninoabril removed the 2: Dev Review Requires review by a core commiter label Oct 12, 2020
srkgupta
srkgupta approved these changes Oct 13, 2020
View reviewed changes
Copy link
Contributor

@srkgupta srkgupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MikeworX. LGTM

@srkgupta srkgupta added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester labels Oct 13, 2020
@srkgupta
Copy link
Contributor

/update-branch

@srkgupta srkgupta merged commit 4ddd8cb into mattermost:master Oct 13, 2020
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Oct 13, 2020
Tak-Iwamoto pushed a commit to Tak-Iwamoto/mattermost-webapp that referenced this pull request Oct 14, 2020
Merge branch 'master' of github.com:Tak-Iwamoto/mattermost-webapp int…
cdc2288 
…o MM-20457

* 'master' of github.com:Tak-Iwamoto/mattermost-webapp: (87 commits)
  MM-T644 Integrations display on team where they were created (mattermost#6752)
  [MM-20478] Migrate post_header module to TypeScript (mattermost#6631)
  [MM-20599] Migrated select_team component to Typescript (mattermost#6574)
  MM-20554 Migrate 'components/delete_post_modal' module and associated tests to TypeScript (mattermost#6656)
  [MM-24436]- Add a threshold from bottom for new messages toast (mattermost#5828)
  [MM-20489] Migrate failed_post_options and its tests to typescript (mattermost#6717)
  [MM-28063] Cloud Telemetry - Admin Console (mattermost#6762)
  [MM-29559][MM-29558] Company Info Fixes (mattermost#6764)
  [MM-29557] [MM-29590] Update subscription when purchase modal closes (mattermost#6765)
  [MM-29615] Fixed subscription page so it doesn't load until subscription info is loaded (mattermost#6766)
  [MM-28064] Add telemetry in various places around cloud message banners (mattermost#6763)
  migrate changeCSS function CSS variable for mobile CSS .tutorial-steps__container selector. (mattermost#6743)
  [MM-27231]: cypress test for MM-T1837 (mattermost#6676)
  [MM-28062] Add telemetry for in-app purchase flow (mattermost#6760)
  MM-27454 - Contact Us and Billing Documentation Links (mattermost#6731)
  [MM-20514] Migrates components/password reset send link to typescript (mattermost#6584)
  Cloud Billing polish Soft GA (mattermost#6740)
  [MM-28221] Payment Info Edit/View (mattermost#6709)
  MM-T636 Description field for incoming and outgoing webhooks can hold 500 characters (mattermost#6682)
  Translations update from Weblate (mattermost#6748)
  ...
@MikeworX MikeworX deleted the description-field-can-hold-500 branch October 16, 2020 00:29
jfrerich pushed a commit that referenced this pull request Oct 23, 2020
@MikeworX @mattermod @jfrerich
MM-T636 Description field for incoming and outgoing webhooks can hold…
dbf93bf 
… 500 characters (#6682)

* first run

* fixes

* refactor, add sanity check

* Delete description_field_for_incoming_and_outgoing_webhooks_can_hold_500_characters_spec.js

name change

* move let into describe block

Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
calebroseland pushed a commit that referenced this pull request Oct 27, 2020
@MikeworX @mattermod @calebroseland
MM-T636 Description field for incoming and outgoing webhooks can hold…
29204d0 
… 500 characters (#6682)

* first run

* fixes

* refactor, add sanity check

* Delete description_field_for_incoming_and_outgoing_webhooks_can_hold_500_characters_spec.js

name change

* move let into describe block

Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
@snyk-bot snyk-bot mentioned this pull request Jan 18, 2022
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@srkgupta srkgupta srkgupta approved these changes

@saturninoabril saturninoabril saturninoabril approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation Hacktoberfest hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
7 participants
@MikeworX @mattermod @srkgupta @saturninoabril @jasonblais @hanzei @amyblais