Navigation Menu

Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

[MM-28062] Add telemetry for in-app purchase flow #6760

Merged
merged 5 commits into from Oct 13, 2020
Merged

[MM-28062] Add telemetry for in-app purchase flow #6760

merged 5 commits into from Oct 13, 2020

Conversation

nickmisasi
Copy link
Contributor

Summary

Adds telemetry tracking for various places in the purchase flow, as described in: https://docs.google.com/document/d/102uElsng_cnpFHAr8tqTEIhktX5x5R9LAxDLBPDOvAU/edit#heading=h.y5i12eg5od68

Ticket Link

https://mattermost.atlassian.net/browse/MM-28062?filter=15333

Related Pull Requests

n/a

Screenshots

n/a

@nickmisasi
Copy link
Contributor Author

nickmisasi commented Oct 13, 2020 •
edited

@Adovenmuehle I've made the following assumption in order to make implementation easier. Let me know if you'd like me to change it:

User clicks on ‘not right now’ on limit modal - I've also had this track when the user clicks the "x" button on the same modal, since they are both doing the same thing - closing the modal.

User clicks on ‘not right now’ on limit modal - the event in the doc is listed as click_modal_user_limit_updgrade (note the spelling of upgrade). I've changed it to click_modal_user_limit_upgrade, I can update the doc for this. Also, I assume this one should read User clicks on "Upgrade Mattermost Cloud" on limit modal

@nickmisasi nickmisasi changed the title Add telemetry for in-app purchase flow [MM-28062] Add telemetry for in-app purchase flow Oct 13, 2020
@nickmisasi nickmisasi added the 2: Dev Review Requires review by a core commiter label Oct 13, 2020
alifarooq0
alifarooq0 approved these changes Oct 13, 2020
View reviewed changes
Copy link
Contributor

@alifarooq0 alifarooq0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @nickmisasi!

Adovenmuehle
Adovenmuehle suggested changes Oct 13, 2020
View reviewed changes
Copy link
Contributor

@Adovenmuehle Adovenmuehle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of nits but otherwise LGTM. Agree with your changes mentioned in your comment.

components/purchase_modal/purchase_modal.tsx Outdated Show resolved Hide resolved
components/purchase_modal/purchase_modal.tsx Outdated Show resolved Hide resolved
components/user_limit_modal/user_limit_modal.tsx Outdated Show resolved Hide resolved
Adovenmuehle
Adovenmuehle approved these changes Oct 13, 2020
View reviewed changes
Copy link
Contributor

@Adovenmuehle Adovenmuehle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@devinbinnie devinbinnie added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter labels Oct 13, 2020
@nickmisasi nickmisasi merged commit 8618aeb into master Oct 13, 2020
@nickmisasi nickmisasi deleted the MM-28062 branch October 13, 2020 17:07
@nickmisasi
Copy link
Contributor Author

/cherry-pick cloud-ga

@mattermod
Copy link
Contributor

Cherry pick is scheduled.

@mattermod
Copy link
Contributor

mattermod commented Oct 13, 2020 •
edited by jira bot

Error trying doing the automated Cherry picking. Please do this manually

+++ Updating remotes...
Fetching upstream
Failed to add the RSA host key for IP address '140.82.114.3' to the list of known hosts (/app/.ssh/known_hosts).
From github.com:mattermost/mattermost-webapp
 * [new branch]          MM-28064   -> upstream/MM-28064
   2d69be5b9..8618aeb2f  master     -> upstream/master
Fetching origin
Failed to add the RSA host key for IP address '140.82.113.4' to the list of known hosts (/app/.ssh/known_hosts).
+++ Updating remotes done...
+++ Creating local branch automated-cherry-pick-of-mattermost-webapp-#6760-upstream-cloud-ga-1602608841
Switched to a new branch 'automated-cherry-pick-of-mattermost-webapp-#6760-upstream-cloud-ga-1602608841'
Branch 'automated-cherry-pick-of-mattermost-webapp-#6760-upstream-cloud-ga-1602608841' set up to track remote branch 'cloud-ga' from 'upstream'.

+++ About to attempt cherry pick of PR #6760 with merge commit 8618aeb2f29bbfe5df2a551b415b4c7818d59eaa.

error: could not apply 8618aeb2f... [MM-28062] Add telemetry for in-app purchase flow (#6760)
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add <paths>' or 'git rm <paths>'
hint: and commit the result with 'git commit'

+++ Conflicts detected:

UU components/purchase_modal/purchase_modal.tsx
Aborting.

+++ Aborting in-progress git cherry-pick.

+++ Returning you to the master branch and cleaning up.

@nickmisasi
Copy link
Contributor Author

Unable to cherry-pick this properly until https://github.com/mattermost/customer-web-server/pull/245 is merged

nickmisasi added a commit that referenced this pull request Oct 13, 2020
@nickmisasi
Cherry picking #6760
30f5340
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Oct 13, 2020
Tak-Iwamoto pushed a commit to Tak-Iwamoto/mattermost-webapp that referenced this pull request Oct 14, 2020
Merge branch 'master' of github.com:Tak-Iwamoto/mattermost-webapp int…
cdc2288 
…o MM-20457

* 'master' of github.com:Tak-Iwamoto/mattermost-webapp: (87 commits)
  MM-T644 Integrations display on team where they were created (mattermost#6752)
  [MM-20478] Migrate post_header module to TypeScript (mattermost#6631)
  [MM-20599] Migrated select_team component to Typescript (mattermost#6574)
  MM-20554 Migrate 'components/delete_post_modal' module and associated tests to TypeScript (mattermost#6656)
  [MM-24436]- Add a threshold from bottom for new messages toast (mattermost#5828)
  [MM-20489] Migrate failed_post_options and its tests to typescript (mattermost#6717)
  [MM-28063] Cloud Telemetry - Admin Console (mattermost#6762)
  [MM-29559][MM-29558] Company Info Fixes (mattermost#6764)
  [MM-29557] [MM-29590] Update subscription when purchase modal closes (mattermost#6765)
  [MM-29615] Fixed subscription page so it doesn't load until subscription info is loaded (mattermost#6766)
  [MM-28064] Add telemetry in various places around cloud message banners (mattermost#6763)
  migrate changeCSS function CSS variable for mobile CSS .tutorial-steps__container selector. (mattermost#6743)
  [MM-27231]: cypress test for MM-T1837 (mattermost#6676)
  [MM-28062] Add telemetry for in-app purchase flow (mattermost#6760)
  MM-27454 - Contact Us and Billing Documentation Links (mattermost#6731)
  [MM-20514] Migrates components/password reset send link to typescript (mattermost#6584)
  Cloud Billing polish Soft GA (mattermost#6740)
  [MM-28221] Payment Info Edit/View (mattermost#6709)
  MM-T636 Description field for incoming and outgoing webhooks can hold 500 characters (mattermost#6682)
  Translations update from Weblate (mattermost#6748)
  ...
jfrerich pushed a commit that referenced this pull request Oct 23, 2020
@nickmisasi @jfrerich
[MM-28062] Add telemetry for in-app purchase flow (#6760)
a00d657 
* Add telemetry for in-app purchase flow

* Fix spelling mistake in telemetry doc

* Fixes

* Fix linter
calebroseland pushed a commit that referenced this pull request Oct 27, 2020
@nickmisasi @calebroseland
[MM-28062] Add telemetry for in-app purchase flow (#6760)
ad5bd80 
* Add telemetry for in-app purchase flow

* Fix spelling mistake in telemetry doc

* Fixes

* Fix linter
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Adovenmuehle Adovenmuehle Adovenmuehle approved these changes

@alifarooq0 alifarooq0 alifarooq0 approved these changes

@devinbinnie devinbinnie devinbinnie approved these changes

Assignees

@nickmisasi nickmisasi

Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation
Projects
None yet
Milestone
No milestone
6 participants
@nickmisasi @mattermod @Adovenmuehle @alifarooq0 @devinbinnie @amyblais