Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

MM-T644 Integrations display on team where they were created #6752

Merged

Conversation

MikeworX
Copy link
Contributor

Summary

This PR validates that incoming web-hook integrations created on separate teams are only visible on the integrations page to the team that created it.

Steps

  • two teams are created
  • two incoming web-=hooks are created, one per team
  • it is asserted that the web-hooks are only visible on the integrations page of the team that created it

Screen Shot 2020-10-12 at 8 25 35 PM

**_Links_**

vercel
TM4J

@mattermod
Copy link
Contributor

Hello @MikeworX,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@lindy65 lindy65 added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels Oct 13, 2020
@lindy65 lindy65 requested a review from larkox October 13, 2020 07:27
Copy link
Contributor

@larkox larkox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks! 🎉

Copy link
Contributor

@srkgupta srkgupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MikeworX. Tested and passed. Test LGTM. Approving the PR.

@srkgupta srkgupta removed the 3: QA Review Requires review by a QA tester label Oct 13, 2020
@hanzei hanzei requested review from catalintomai and removed request for jfrerich October 13, 2020 14:22
@lindy65 lindy65 added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter labels Oct 14, 2020
@hanzei
Copy link
Contributor

hanzei commented Oct 14, 2020

/update-branch

@hanzei hanzei merged commit 260fcd7 into mattermost:master Oct 14, 2020
@hanzei
Copy link
Contributor

hanzei commented Oct 14, 2020

Thanks for helping Mattermost with more E2E tests 🚀

Tak-Iwamoto pushed a commit to Tak-Iwamoto/mattermost-webapp that referenced this pull request Oct 14, 2020
…o MM-20457

* 'master' of github.com:Tak-Iwamoto/mattermost-webapp: (87 commits)
  MM-T644 Integrations display on team where they were created (mattermost#6752)
  [MM-20478] Migrate post_header module to TypeScript (mattermost#6631)
  [MM-20599] Migrated select_team component to Typescript (mattermost#6574)
  MM-20554 Migrate 'components/delete_post_modal' module and associated tests to TypeScript (mattermost#6656)
  [MM-24436]- Add a threshold from bottom for new messages toast (mattermost#5828)
  [MM-20489] Migrate failed_post_options and its tests to typescript (mattermost#6717)
  [MM-28063] Cloud Telemetry - Admin Console (mattermost#6762)
  [MM-29559][MM-29558] Company Info Fixes (mattermost#6764)
  [MM-29557] [MM-29590] Update subscription when purchase modal closes (mattermost#6765)
  [MM-29615] Fixed subscription page so it doesn't load until subscription info is loaded (mattermost#6766)
  [MM-28064] Add telemetry in various places around cloud message banners (mattermost#6763)
  migrate changeCSS function CSS variable for mobile CSS .tutorial-steps__container selector. (mattermost#6743)
  [MM-27231]: cypress test for MM-T1837 (mattermost#6676)
  [MM-28062] Add telemetry for in-app purchase flow (mattermost#6760)
  MM-27454 - Contact Us and Billing Documentation Links (mattermost#6731)
  [MM-20514] Migrates components/password reset send link to typescript (mattermost#6584)
  Cloud Billing polish Soft GA (mattermost#6740)
  [MM-28221] Payment Info Edit/View (mattermost#6709)
  MM-T636 Description field for incoming and outgoing webhooks can hold 500 characters (mattermost#6682)
  Translations update from Weblate (mattermost#6748)
  ...
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Oct 14, 2020
@MikeworX MikeworX deleted the integrations_display_on_team_where_created branch October 16, 2020 00:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation Hacktoberfest hacktoberfest-accepted
Projects
None yet
8 participants