[MM-56902] Minor selector improvements #26372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mm-cloud-bot
added
the
release-note-none
hmhealey
reviewed
Mar 5, 2024
webapp/channels/src/components/admin_console/license_settings/trial_banner/trial_banner.tsx
Outdated
Show resolved
Hide resolved
webapp/channels/src/components/common/hooks/useExpandOverageUsersCheck.ts
Outdated
Show resolved
Hide resolved
webapp/channels/src/packages/mattermost-redux/src/selectors/entities/channels.ts
Show resolved
Hide resolved
M-ZubairAhmed
requested review from
larkox
and removed request for
M-ZubairAhmed
larkox
approved these changes
May 6, 2024
hmhealey
approved these changes
May 7, 2024
amyblais
added
Changelog/Not Needed
jwilander
added
the
kind/refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I noticed these issues by looking at our selector telemetry and running profilers. Some of these were re-rendering a lot. I have not been able to test if I broke anything with these because I'm not even sure how to surface these components.
Ticket Link
https://mattermost.atlassian.net/browse/MM-56902
Screenshots
Release Note