[MM-57106] Remove unused cluster settings #26490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mm-cloud-bot
added
the
release-note
hanzei
commented
Mar 18, 2024
| @@ -33,7 +33,7 @@ func TestUpdateConfigRace(t *testing.T) { | |||
|
|
|||
| cfg := &model.Config{} | |||
| cfg.SetDefaults() | |||
| cfg.ClusterSettings.MaxIdleConns = model.NewInt(1) | |||
| cfg.ClusterSettings.GossipPort = model.NewInt(9999) | |||
There was a problem hiding this comment.
Needed another setting for the test
hanzei
added
2: Dev Review
|
E2E tests not automatically triggered, because the PR is not in a mergeable state. Please update the branch with the base branch and resolve outstanding conflicts. |
|
/e2e-test |
|
Successfully triggered E2E testing! |
|
E2E tests look good. Merging. |
|
@cwarnermm Heads up that doc updates are required for this PR. Please let me know if you need anything from me. Should be straightforward to move the removed cluster settings to the legacy config page. |
jwilander
added
the
kind/refactor
amyblais
added
Docs/Done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The settings
StreamingPort,MaxIdleConns,MaxIdleConnsPerHostandIdleConnTimeoutMillisecondswere unused and had no effect. This PR cleans them up from the codebase.Ticket Link
https://mattermost.atlassian.net/browse/MM-57106
Release Note