This repository has been archived by the owner on Jul 5, 2024. It is now read-only.
commands/init: version check revamped to indicate errors #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agnivade
approved these changes
May 13, 2022
added you the the channel: https://community-daily.mattermost.com/core/pl/15d6kpr8kfnq5jco8zny3mr69r |
ghost
approved these changes
May 16, 2022
isacikgoz
added
4: Reviews Complete
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix an issue where we were silently overlooking the error. If we have major version differences or client is ahead of the server we raise a warning. We don't need to raise a warning if the server is ahead of client on the minor version. We need to be backwards compatible.