-
Notifications
You must be signed in to change notification settings - Fork 154
[MM-47825] refactor rolesSystemAdminCmdF function to return an error #21477 #592
[MM-47825] refactor rolesSystemAdminCmdF function to return an error #21477 #592
Conversation
Hello @yakuter, Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here. Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project. Please help complete the Mattermost contribution license agreement? This is a standard procedure for many open source projects. Please let us know if you have any questions. We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team. |
/check-cla |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @yakuter, thank you very much for your contribution. I'd like to request a few minor changes, other than that it looks very good.
@noxer thank you for the review. I solved and commited all the things you mentioned. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just two minor adjustments, then we're done ;)
edit: One. Just one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, thank you very much!
Thanks to you @noxer :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks for the contribution @yakuter 🎉
Thanks for your support for my first PR to mattermost @noxer @isacikgoz 🥳 |
Summary
Added multi error handing in rolesSystemAdminCmdF function
Ticket Link
Fixes: mattermost/mattermost#21477
JIRA: https://mattermost.atlassian.net/browse/MM-47825