Skip to content
This repository has been archived by the owner on Jul 5, 2024. It is now read-only.

[MM-47825] refactor rolesSystemAdminCmdF function to return an error #21477 #592

Merged
merged 4 commits into from
Oct 25, 2022

Conversation

yakuter
Copy link
Contributor

@yakuter yakuter commented Oct 24, 2022

Summary

Added multi error handing in rolesSystemAdminCmdF function

Ticket Link

Fixes: mattermost/mattermost#21477
JIRA: https://mattermost.atlassian.net/browse/MM-47825

@mattermod
Copy link
Contributor

Hello @yakuter,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project.

Please help complete the Mattermost contribution license agreement?
Once you have signed the CLA, please comment with /check-cla and confirm that the CLA check is green.

This is a standard procedure for many open source projects.

Please let us know if you have any questions.

We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.

@yakuter
Copy link
Contributor Author

yakuter commented Oct 24, 2022

/check-cla

@noxer noxer requested review from isacikgoz and noxer October 24, 2022 16:31
@noxer noxer added the 2: Dev Review Requires review by a core committer label Oct 24, 2022
Copy link
Contributor

@noxer noxer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @yakuter, thank you very much for your contribution. I'd like to request a few minor changes, other than that it looks very good.

commands/roles.go Outdated Show resolved Hide resolved
commands/roles.go Outdated Show resolved Hide resolved
commands/roles_test.go Outdated Show resolved Hide resolved
commands/roles_test.go Outdated Show resolved Hide resolved
@yakuter yakuter requested review from noxer and removed request for isacikgoz October 24, 2022 17:26
@yakuter
Copy link
Contributor Author

yakuter commented Oct 24, 2022

@noxer thank you for the review. I solved and commited all the things you mentioned.

Copy link
Contributor

@noxer noxer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two minor adjustments, then we're done ;)
edit: One. Just one.

commands/roles.go Outdated Show resolved Hide resolved
@yakuter yakuter requested a review from noxer October 24, 2022 17:36
@noxer noxer requested a review from isacikgoz October 24, 2022 18:01
Copy link
Contributor

@noxer noxer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you very much!

@yakuter
Copy link
Contributor Author

yakuter commented Oct 24, 2022

Perfect, thank you very much!

Thanks to you @noxer :)

Copy link
Member

@isacikgoz isacikgoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for the contribution @yakuter 🎉

@isacikgoz isacikgoz added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Oct 25, 2022
@isacikgoz isacikgoz merged commit 993ca38 into mattermost:master Oct 25, 2022
@yakuter
Copy link
Contributor Author

yakuter commented Oct 25, 2022

Thanks for your support for my first PR to mattermost @noxer @isacikgoz 🥳

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
4: Reviews Complete All reviewers have approved the pull request Hacktoberfest hacktoberfest-accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mmctl: Review rolesSystemAdminCmdF function to return an error in case of a failure
4 participants