Skip to content
This repository has been archived by the owner on Jul 5, 2024. It is now read-only.

[MM-47812] Refactor addUserToTeam function to return an error #603

Merged
merged 5 commits into from
Nov 8, 2022
Merged

[MM-47812] Refactor addUserToTeam function to return an error #603

merged 5 commits into from
Nov 8, 2022

Conversation

svbnbyrk
Copy link
Contributor

Summary

Added multi-error handling for teamUsersAddCmdF func.

Ticket Link

Issue: mattermost/mattermost/issues/21474
Jira: https://mattermost.atlassian.net/browse/MM-47812

@mattermod
Copy link
Contributor

Hello @svbnbyrk,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project.

Please help complete the Mattermost contribution license agreement?
Once you have signed the CLA, please comment with /check-cla and confirm that the CLA check is green.

This is a standard procedure for many open source projects.

Please let us know if you have any questions.

We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.

@svbnbyrk
Copy link
Contributor Author

/check-cla

@noxer noxer added the 2: Dev Review Requires review by a core committer label Oct 31, 2022
noxer
noxer suggested changes Oct 31, 2022
View reviewed changes
Copy link
Contributor

@noxer noxer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your contribution @svbnbyrk. There are a few issues with the code formatting and I've suggested a small change in the test code. Otherwise this looks good.

commands/team_users_e2e_test.go Outdated Show resolved Hide resolved
commands/team_users_e2e_test.go Outdated Show resolved Hide resolved
commands/team_users_e2e_test.go Outdated Show resolved Hide resolved
commands/team_users_test.go Outdated Show resolved Hide resolved
@svbnbyrk
Copy link
Contributor Author

Hi @noxer, I resolved all conversations.

@svbnbyrk svbnbyrk requested a review from noxer October 31, 2022 12:07
@svbnbyrk
Copy link
Contributor Author

svbnbyrk commented Nov 6, 2022

I didn't get any unit test, e2e test or lint errors. It seems ok.

@svbnbyrk
Copy link
Contributor Author

svbnbyrk commented Nov 7, 2022

/update-branch

svbnbyrk
svbnbyrk commented Nov 7, 2022
View reviewed changes
Copy link
Contributor Author

@svbnbyrk svbnbyrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok.

@svbnbyrk svbnbyrk marked this pull request as draft November 7, 2022 17:14
@svbnbyrk svbnbyrk marked this pull request as ready for review November 7, 2022 17:15
noxer
noxer approved these changes Nov 8, 2022
View reviewed changes
Copy link
Contributor

@noxer noxer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your contribution @svbnbyrk. I've added Ibrahim as the second reviewer. We'll merge it as soon as he approves.

@noxer noxer requested a review from isacikgoz November 8, 2022 10:30
isacikgoz
isacikgoz approved these changes Nov 8, 2022
View reviewed changes
Copy link
Member

@isacikgoz isacikgoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution @svbnbyrk 🥇

@isacikgoz isacikgoz added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Nov 8, 2022
@isacikgoz isacikgoz merged commit 02fea7a into mattermost:master Nov 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@isacikgoz isacikgoz isacikgoz approved these changes

@noxer noxer noxer approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request Hacktoberfest hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@svbnbyrk @mattermod @noxer @isacikgoz