Allow for Consul UI w/o nginx install #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I set the variables to true to preserve backwards compatibility, but I do think they should be false by default. |
mattfinlayson
added a commit
that referenced
this pull request
Jan 14, 2016
Allow for Consul UI w/o nginx install
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added two new variables:
consul_install_nginx: true
consul_install_nginx_config: true
To allow for Consul UI install w/o nginx - I feel it's common for people to have their own roles for nginx and the fact that nginx is installed potentially conflicts with that and was a suprise for me as well.
Also set to latest Consul version and updated README for that.