Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add support for 'vi' if 'ed' isn't installed #53

Merged
merged 8 commits into from
Jun 14, 2024
Merged

fix: Add support for 'vi' if 'ed' isn't installed #53

merged 8 commits into from
Jun 14, 2024

Conversation

matthewfeickert
Copy link
Owner

@matthewfeickert matthewfeickert commented Jun 14, 2024 •
edited
Loading

Resolves #52

As a full text editor is useful for writing the complicated multi-line patches into the activate script, fall back to using vi if ed is not installed.

* As a full text editor is useful for writing the complicated multi-line
  patches into the 'activate' script, fall back to using 'vi' if 'ed' is
  not installed.
* Note that 'ed' or 'vi' works in the README.

@matthewfeickert
fix: Use 'cat' over 'ed'
44dc7ec 
* Some el9 distributions do not have 'ed' by default, so use 'cat'
  as that is more ubiquitous.
* Remove mention of 'ed' from README.
@matthewfeickert
Revert "fix: Use 'cat' over 'ed'"
f160d96 
This reverts commit 44dc7ec.
@matthewfeickert
fix: Use 'sed' over 'ed'
a6dcd0f 
* Some el9 distributions do not have 'ed' by default, so use 'sed'
  as that is more ubiquitous.
* Remove mention of 'ed' from README
@matthewfeickert
Add ed or vi support
0185b81
@matthewfeickert
remove echos
a722c0e
@matthewfeickert
Note either ed or vi works
503dc29
@matthewfeickert
Add fixme
7960d11
@matthewfeickert matthewfeickert self-assigned this Jun 14, 2024
@matthewfeickert matthewfeickert merged commit b44a482 into main Jun 14, 2024
4 checks passed
@matthewfeickert matthewfeickert deleted the fix/use-cat-over-ed-for-el9 branch June 14, 2024 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@matthewfeickert matthewfeickert

Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use sed over ed
1 participant
@matthewfeickert