Update index.js #53
Closed
Update index.js #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix to .limit(n): if the next page is not a url (e.g. the link is broken or we reached the last page), the method should return fn(null, pages), and not call fn(null, pages) and continue to the next page.
|
Doh, good catch. If you have a chance, would you mind adding a test? |
cosminonea
added a commit
to cosminonea/x-ray
that referenced
this pull request
Jun 24, 2015
When reaching the last page the callback function is called twice. This fixes matthewmueller#53 Added a test but it’s a bit messy because it’s a negative test and I am not a javascript dev so I hope someone can refactor it in a more elegant way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix to .limit(n): if the next page is not a url (e.g. the link is broken or we reached the last page), the method should return fn(null, pages), and not call fn(null, pages) and continue to the next page.
Right now, x-ray crashes if the we choose n > number of pages in limit(n), whereas it should just return the fn(null, pages) once it reaches the end.