Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace mcrypt with OpenSSL #45

Closed
mattheworres opened this issue Feb 12, 2018 · 1 comment
Closed

Replace mcrypt with OpenSSL #45

mattheworres opened this issue Feb 12, 2018 · 1 comment
Assignees
Labels
bug good first issue in-progress tech-debt Issues that affect code quality, but not app features
Milestone

Comments

@mattheworres
Copy link
Owner

In PHP 7.2 they are officially removing mcrypt from the PHP library (it was marked as deprecated in 7.1), so in order to keep the project compatible on the newest versions of PHP, the use of Mcrypt in the Salt Service will need to be migrated to use OpenSSL instead, and a suitable way to convert values generated by Mcrypt to values created by OpenSSL will be needed too.

@mattheworres mattheworres added tech-debt Issues that affect code quality, but not app features in-progress labels Jan 2, 2019
@mattheworres
Copy link
Owner Author

This was actually way easier than I at one point thought, and I erroneously dove down the rabbit hole of completely re-doing the auth scheme in the app (which I've come to the conclusion will require moving off of Silex, and onto Symfony 4 - a future item, but a large refactor). Instead, just replace the mcrypt method and call it a day. Old salts generated with mcrypt are OK, the primary concern here is not one of security, but rather platform compatibility. PHP7.2 servers won't be able to have mcrypt installed, but OpenSSL comes by default.

@mattheworres mattheworres self-assigned this Jan 9, 2019
@mattheworres mattheworres added this to the 2.3.0 milestone Jan 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug good first issue in-progress tech-debt Issues that affect code quality, but not app features
Projects
None yet
Development

No branches or pull requests

1 participant