fix: do not fire promise events after state changes #171
Conversation
|
@matthewp any thoughts on this? |
|
Is this how Xstate works? |
|
@matthewp Yes, here is an example https://codesandbox.io/s/suspicious-pare-137g4z |
machine.js
Outdated
| .then(data => service.send({ type: 'done', data })) | ||
| .catch(error => service.send({ type: 'error', error })); | ||
| .then(data => { | ||
| if (machine.state.name === service.machine.state.name) |
There was a problem hiding this comment.
Since every step generates a new machine, wouldn't it be enough to compare the value of machine versus service.machine? It would address the case where the state machine has returned to the same state before the promise resolves.
|
Sorry for the delay @kybarg, can you address @ehuelsmann's review and update the branch? |
kybarg
force-pushed
the
invoke-promise-fix
branch
from
b6b599d
to
0952fb0
Compare
|
@matthewp done |
|
Could we merge and release this? It seems that the approach was approved, it was just never merged. |
|
@matthewp, I don't mind updating this PR so you can include it in a next release. I'll need to create a new PR though, because I can't append to this one. Are you fine with that? Does it make sense for me to work on this? |
|
@ehuelsmann yep, works for me |
kybarg
force-pushed
the
invoke-promise-fix
branch
from
3edaa3f
to
0b2caf1
Compare
|
fixes #141