Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMake project and CI refactor #15

Merged
merged 6 commits into from
May 11, 2023
Merged

CMake project and CI refactor #15

merged 6 commits into from
May 11, 2023

Conversation

AlvaroFS
Copy link
Contributor

@AlvaroFS AlvaroFS commented May 11, 2023 •
edited
Loading

I added a CMake file to the project to build it on Windows.
I also unified the jobs in the CI workflow and added a job for Windows. That job is currently disabled since it doesn't pass because of some gnu extensions used portability issues.

Álvaro FS added 3 commits May 11, 2023 03:01
Add CMake project
ebdbaed
Update CI.
eebe1ae 
- Renamed workflow.
- Unify gcc jobs using matrix.
- Clang job using matrix.
- Add MSVC job (disabled).
Rename workflow file
6dbf4c3
mattkretz
mattkretz requested changes May 11, 2023
View reviewed changes
Copy link
Owner

@mattkretz mattkretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This looks great. My cmake is getting rusty and what you wrote looks much better than what I would have hacked up 😉

I mentioned PR #14 in one comment. I will rebase #14 on top of your work as soon as we get it in. So don't bother about any conflicts between these PRs.

CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
.github/workflows/CI.yml Outdated Show resolved Hide resolved
.github/workflows/CI.yml Outdated Show resolved Hide resolved
@mattkretz mattkretz self-assigned this May 11, 2023
@mattkretz mattkretz added the enhancement New feature or request label May 11, 2023
@mattkretz mattkretz added this to the v0.3.0 milestone May 11, 2023
mattkretz
mattkretz approved these changes May 11, 2023
View reviewed changes
Copy link
Owner

@mattkretz mattkretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@mattkretz mattkretz merged commit 718b9ea into mattkretz:master May 11, 2023
@AlvaroFS AlvaroFS deleted the msvc_gha branch May 22, 2023 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattkretz mattkretz mattkretz approved these changes

Assignees

@mattkretz mattkretz

Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@AlvaroFS @mattkretz