Skip to content

Allow the dropdown menu resize so that user can drag the dropdown menu to a desirable size. #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

tomtom73
Copy link
Contributor

@tomtom73 tomtom73 commented Jul 5, 2018

Allow the dropdown menu resize so that user can drag the dropdown menu to a desirable size.

@tomtom73 tomtom73 changed the title Update text-input-autocomplete-menu.component.ts Allow the dropdown menu resize so that user can drag the dropdown menu to a desirable size. Jul 5, 2018
@codecov-io
Copy link

Codecov Report

Merging #8 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master       #8   +/-   ##
=======================================
  Coverage   93.84%   93.84%           
=======================================
  Files           5        5           
  Lines         130      130           
  Branches       18       18           
=======================================
  Hits          122      122           
  Misses          2        2           
  Partials        6        6
Impacted Files Coverage Δ
src/text-input-autocomplete-menu.component.ts 86.11% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb1e5fe...916e9d3. Read the comment docs.

@mattlewis92
Copy link
Owner

Hey, thanks for this! Unfortunately because of the max-height: 200px this doesn't actually let you resize the menu more than that. What do you think about instead adding a selector to the dropdown so you can style the menu yourself and remove the max-height and add this rule instead?

@tomtom73
Copy link
Contributor Author

tomtom73 commented Jul 7, 2018 via email

@mattlewis92
Copy link
Owner

Released as 0.3.0 🎉

@tomtom73
Copy link
Contributor Author

tomtom73 commented Jul 9, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants