Python 3 support (#7) #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # .circleci/config.yml # Makefile
These namespace relative imports work in chumpy tests, but were causing import errors like this one:
```
File "/home/circleci/repo/blmath/geometry/transform/test_composite.py", line 172, in test_forward_reverse_equivalence
transform.rotate(np.array([1., 2., 3.]))
File "/home/circleci/repo/blmath/geometry/transform/composite.py", line 237, in rotate
from blmath.geometry.transform.rodrigues import as_rotation_matrix
File "/home/circleci/repo/blmath/geometry/transform/rodrigues.py", line 2, in <module>
import chumpy as ch
File "/home/circleci/repo/venv/lib/python2.7/site-packages/chumpy/__init__.py", line 1, in <module>
from .ch import *
File "/home/circleci/repo/venv/lib/python2.7/site-packages/chumpy/ch.py", line 1310, in <module>
from . import ch_ops
File "/home/circleci/repo/venv/lib/python2.7/site-packages/chumpy/ch_ops.py", line 47, in <module>
from . import ch
ImportError: cannot import name ch
```
# Conflicts:
# Makefile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #10.
I have Circle updates to test on both versions (see metabolize-forks#7) but it depends on #27 so I didn't include it here.