Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3 support (#7) #28

Merged
merged 2 commits into from Mar 14, 2019

Conversation

Projects
None yet
2 participants
@paulmelnikow
Copy link
Contributor

commented Jul 15, 2018

Alternative to #10.

I have Circle updates to test on both versions (see metabolize#7) but it depends on #27 so I didn't include it here.

Python 3 support (#7)
# Conflicts:
#	.circleci/config.yml
#	Makefile
Fix relative imports after pip installation (#11)
These namespace relative imports work in chumpy tests, but were causing import errors like this one:

```
  File "/home/circleci/repo/blmath/geometry/transform/test_composite.py", line 172, in test_forward_reverse_equivalence
    transform.rotate(np.array([1., 2., 3.]))
  File "/home/circleci/repo/blmath/geometry/transform/composite.py", line 237, in rotate
    from blmath.geometry.transform.rodrigues import as_rotation_matrix
  File "/home/circleci/repo/blmath/geometry/transform/rodrigues.py", line 2, in <module>
    import chumpy as ch
  File "/home/circleci/repo/venv/lib/python2.7/site-packages/chumpy/__init__.py", line 1, in <module>
    from .ch import *
  File "/home/circleci/repo/venv/lib/python2.7/site-packages/chumpy/ch.py", line 1310, in <module>
    from . import ch_ops
  File "/home/circleci/repo/venv/lib/python2.7/site-packages/chumpy/ch_ops.py", line 47, in <module>
    from . import ch
ImportError: cannot import name ch
```
# Conflicts:
#	Makefile

@mattloper mattloper merged commit a3cfdb1 into mattloper:master Mar 14, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.