Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installer scripts are not working if bash does not exists on /bin/bash #126

Closed
nyarla opened this issue Jan 30, 2020 · 0 comments · Fixed by #127
Closed

Installer scripts are not working if bash does not exists on /bin/bash #126

nyarla opened this issue Jan 30, 2020 · 0 comments · Fixed by #127

Comments

@nyarla
Copy link

nyarla commented Jan 30, 2020

Hi,

Some Language server installer scripts for unix-like environemt are using hard-coded /bin/bash in shebang, but it's not working if bash does not exists /bin/bash.

For examples, I'm using NixOS Linux and NixOS does not have executable binary on /bin or /usr/bin, that has executable binary on /run/current-system/sw/bin.

I also think that another case, if vim-lsp-settings users does not installed bash, that case is also not working by /bin/bash does not exists.

So I think that installer scripts should not use hard-coded /bin/bash, I suggest shebang of installer scripts are changes to /usr/bin/env sh or /bin/sh.

Or another suggestion, it's configurable by vimrc about execute shell for installer scripts.

@nyarla nyarla changed the title Installer scripts are not working if bash does not exists /bin/bash Installer scripts are not working if bash does not exists on /bin/bash Jan 30, 2020
@mattn mattn mentioned this issue Jan 30, 2020
nyarla pushed a commit to nyarla/vim-lsp-settings that referenced this issue Jan 30, 2020
mattn added a commit that referenced this issue Jan 30, 2020
fix: Fix bash throws bad interpreter error by fix commit about #126
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant