Fix incompatibility w/ Portable.BouncyCastle 1.9.0 #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resolves the "Cannot Access a closed stream" error during decryption by delaying disposal of all streams returned from `GetDataStream`. Fixes #140
|
Thanks for submitting this PR. I've merged the changes into main and published an updated v5.9.0 package to NuGet. Hopefully this will be all sorted now. |
This was referenced Sep 5, 2022
@mattosaurus Did you intend to say v5.8.0? If so, the new v5.8.0 NuGet package does not seem to contain my changes. The v5.8.0 tag does contain my changes so I'm not sure what happened there. I confirmed with JetBrains dotPeek: |
|
I did mean v5.8.0 but it looks like I built and published the package without syncing to pick up your changes. I've published a v5.8.1 now which (hopefully) includes them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves the "Cannot Access a closed stream" error during decryption by delaying disposal of all streams returned from
GetDataStream.Fixes #140
Adapted from #155