-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Django 1.10 support #18
Conversation
Travis already has its own version of Pytest installed, but that version is too old for one of our dev dependencies
Basically, anything that pytest-django doesn't support Also remove pypy3 because it's still on Python 3.2
1 similar comment
Is it possible to at least maintain 1.6 support? Otherwise, I can't merge this. The main consumer of this project, Sentry, is on 1.6, and I'd rather not maintain awkward branches and two codebases. |
1 similar comment
3 similar comments
Not testing on Python 3.2/pypy3 as it causes no end of errors.
1 similar comment
I have no idea what's going on with @coveralls right now |
Django 1.6 support is back in, but I've left out Python 3.2 and pypy3 tests because they wouldn't work with test coverage (Python 3.2 doesn't support |
Would be great to see this merged :) |
@mattrobenolt Are we good to merge this in now? |
1 similar comment
Added Django 1.11 to the test matrix too, as there's no code change required on top of 1.10 support |
Please merge :) |
@gabn88 if you don't have anything useful to add to this PR, please don't comment. |
Could be interesting to add to the docs and README that this package is compatible with Django 1.10 and 1.11. |
Closing this PR as I'm no longer using this package. https://github.com/justinmayer/django-elevate is a fork of this project that has Django 1.11 support if you need that. |
Adds support for Django 1.10 and drops support for 1.4, 1.5, and 1.6
Django 1.10 no longer supports the dotted notation in url patterns, so we now try to import the dotted string in
redirect_to_sudo
. The middleware has also been updated to work with the new style middleware (though I've not used it in a project yet)The latest version of pytest-django has dropped support for Django 1.4, 1.5, and 1.6, so I've dropped them from the Travis test matrix (I was having issues with the pytest installed on Travis and pytest-django). I've removed all Django 1.4 compatibility code too.