Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Django 1.10 support #18

Closed
wants to merge 9 commits into from
Closed

Django 1.10 support #18

wants to merge 9 commits into from

Conversation

moggers87
Copy link

Adds support for Django 1.10 and drops support for 1.4, 1.5, and 1.6

Django 1.10 no longer supports the dotted notation in url patterns, so we now try to import the dotted string in redirect_to_sudo. The middleware has also been updated to work with the new style middleware (though I've not used it in a project yet)

The latest version of pytest-django has dropped support for Django 1.4, 1.5, and 1.6, so I've dropped them from the Travis test matrix (I was having issues with the pytest installed on Travis and pytest-django). I've removed all Django 1.4 compatibility code too.

Travis already has its own version of Pytest installed, but that version
is too old for one of our dev dependencies
Basically, anything that pytest-django doesn't support

Also remove pypy3 because it's still on Python 3.2
@coveralls
Copy link

coveralls commented Jan 8, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 4947a3b on moggers87:django-1.10 into 089e21a on mattrobenolt:master.

1 similar comment
@coveralls
Copy link

coveralls commented Jan 8, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 4947a3b on moggers87:django-1.10 into 089e21a on mattrobenolt:master.

@mattrobenolt
Copy link
Owner

Is it possible to at least maintain 1.6 support? Otherwise, I can't merge this. The main consumer of this project, Sentry, is on 1.6, and I'd rather not maintain awkward branches and two codebases.

@coveralls
Copy link

coveralls commented Jan 8, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 233272c on moggers87:django-1.10 into 089e21a on mattrobenolt:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 233272c on moggers87:django-1.10 into 089e21a on mattrobenolt:master.

@coveralls
Copy link

coveralls commented Jan 8, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 62a31fb on moggers87:django-1.10 into 089e21a on mattrobenolt:master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 62a31fb on moggers87:django-1.10 into 089e21a on mattrobenolt:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 62a31fb on moggers87:django-1.10 into 089e21a on mattrobenolt:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 62a31fb on moggers87:django-1.10 into 089e21a on mattrobenolt:master.

Not testing on Python 3.2/pypy3 as it causes no end of errors.
@coveralls
Copy link

coveralls commented Jan 8, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 77072be on moggers87:django-1.10 into 089e21a on mattrobenolt:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 77072be on moggers87:django-1.10 into 089e21a on mattrobenolt:master.

@moggers87
Copy link
Author

I have no idea what's going on with @coveralls right now

@moggers87
Copy link
Author

Django 1.6 support is back in, but I've left out Python 3.2 and pypy3 tests because they wouldn't work with test coverage (Python 3.2 doesn't support u''). Technically they still work, so if you'd prefer running tests against those versions over test coverage reports I can do that.

@gabn88
Copy link

gabn88 commented Jan 16, 2017

Would be great to see this merged :)

@QasimK
Copy link

QasimK commented Mar 18, 2017

@mattrobenolt Are we good to merge this in now?

@coveralls
Copy link

coveralls commented Apr 20, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 67a79da on moggers87:django-1.10 into 089e21a on mattrobenolt:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 67a79da on moggers87:django-1.10 into 089e21a on mattrobenolt:master.

@moggers87
Copy link
Author

Added Django 1.11 to the test matrix too, as there's no code change required on top of 1.10 support

@gabn88
Copy link

gabn88 commented Jul 18, 2017

Please merge :)

@moggers87
Copy link
Author

@gabn88 if you don't have anything useful to add to this PR, please don't comment.

@marctc
Copy link

marctc commented Sep 20, 2017

Could be interesting to add to the docs and README that this package is compatible with Django 1.10 and 1.11.

@moggers87
Copy link
Author

Closing this PR as I'm no longer using this package.

https://github.com/justinmayer/django-elevate is a fork of this project that has Django 1.11 support if you need that.

@moggers87 moggers87 closed this May 22, 2018
@moggers87 moggers87 deleted the django-1.10 branch May 22, 2018 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants