This repository has been archived by the owner on Jul 30, 2024. It is now read-only.
slight refactor of Security.__getattr__ to avoid recussion when not initialized with app #339
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you use the factory method for creating at app and call
security.init_app(app)
directly aftersecurity
is initialized, callingsecurity.anything
(I ran into it withsecurity.login_context_processor
) ends up with an endless recursion sincesecurity._state
is never set. This slight changes fixes this, but requires that attributes be accessed within anapp
context when they are registered this way (which is the only way I think it could work, if we are able to register with multiple apps).