Skip to content
This repository has been archived by the owner on Jul 30, 2024. It is now read-only.

Rebased: Allows field labels to be set in config #390

Closed
wants to merge 3 commits into from

Conversation

felix1m
Copy link

@felix1m felix1m commented May 17, 2015

see #203
credits to @maebert

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 94.57% when pulling da8c391 on felix1m:develop into 8a14aba on mattupstate:develop.

@jonafato
Copy link
Contributor

This failed to build for a few reasons:

  • There are a few PEP8 formatting errors. These should be easy fixes.
  • On Python 3, unicode is removed. This can be solved by conditionally using unicode or str depending version (e.g. sys.version_info[0] > 3).

@mattupstate
Copy link
Contributor

You can use flask_security.utils.string_types and flask_security.utils.text_type instead of rolling your own check.

@jonafato
Copy link
Contributor

@mattupstate +1 I knew that had to exist somewhere in the project but overlooked utils for some reason.

@felix1m
Copy link
Author

felix1m commented Jul 23, 2015

someone still interested in getting this merged? Did not find the time so far..

@felix1m
Copy link
Author

felix1m commented Jul 26, 2015

okay, i found the time, took only a second :)

@CatarinaPBressan
Copy link

Hello, is there any plans to merge this PR? I could really use this.

@@ -175,6 +175,23 @@
'Please reauthenticate to access this page.', 'info'),
}


_default_field_labels = {
'EMAIL': 'Email Address',
Copy link
Contributor

@jirikuncar jirikuncar Jul 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to mark the values with _(...) for better i18n support.

@felix1m felix1m closed this Oct 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging this pull request may close these issues.

6 participants