This repository has been archived by the owner on Jul 30, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 512
Rebased: Allows field labels to be set in config #390
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This failed to build for a few reasons:
|
You can use |
@mattupstate +1 I knew that had to exist somewhere in the project but overlooked utils for some reason. |
someone still interested in getting this merged? Did not find the time so far.. |
okay, i found the time, took only a second :) |
Hello, is there any plans to merge this PR? I could really use this. |
jirikuncar
reviewed
Jul 5, 2018
@@ -175,6 +175,23 @@ | |||
'Please reauthenticate to access this page.', 'info'), | |||
} | |||
|
|||
|
|||
_default_field_labels = { | |||
'EMAIL': 'Email Address', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to mark the values with _(...)
for better i18n support.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #203
credits to @maebert