Skip to content
This repository has been archived by the owner on Jul 30, 2024. It is now read-only.

replace token loader with request loader to fix #81 #558

Merged
merged 2 commits into from
Apr 27, 2017
Merged

replace token loader with request loader to fix #81 #558

merged 2 commits into from
Apr 27, 2017

Conversation

alanhamlett
Copy link
Contributor

@alanhamlett alanhamlett commented Oct 27, 2016

Just moved some code around, but the main change is using request_loader on the login manager instead of token_loader to fix #557.

@coveralls
Copy link

coveralls commented Oct 27, 2016

Coverage Status

Coverage remained the same at 94.283% when pulling 01a0d62 on alanhamlett:replace-token-loader-with-request-loader into 9e5865d on mattupstate:develop.

@jonafato
Copy link
Contributor

Flask-Security's dependency on Flask-Login is version-restricted. Can you update the versions with this change?

@coveralls
Copy link

coveralls commented Oct 27, 2016

Coverage Status

Coverage remained the same at 94.283% when pulling 6d56450 on alanhamlett:replace-token-loader-with-request-loader into 9e5865d on mattupstate:develop.

@datashaman
Copy link

Is something holding this up?

@alanhamlett
Copy link
Contributor Author

Is something holding this up?

Not that I know of, I think the maintainers forgot to merge it.

@datashaman
Copy link

datashaman commented Jan 25, 2017

For anyone else faced with this, put: Flask-Login===0.3.2 into your requirements.txt, run pip install -r requirements.txt and it will automagically do the right thing. :-)

Not ideal, but it will suffice until this is merged.

@jirikuncar
Copy link
Contributor

@datashaman you can replace Flask-Security dependency with Flask-Security-Fork which includes this patch (no need to change imports since it's drop-in replacement).

@datashaman
Copy link

@jirikuncar thanks!

@chrisutpg
Copy link

Jirikuncar, thanks for the heads up! That saved me!

@jirikuncar jirikuncar merged commit 6d56450 into pallets-eco:develop Apr 27, 2017
@alanhamlett alanhamlett deleted the replace-token-loader-with-request-loader branch April 27, 2017 07:07
@alanhamlett
Copy link
Contributor Author

alanhamlett commented Apr 27, 2017

Thanks @jirikuncar!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

token_loader method of Flask-Login's LoginManager object has been removed
6 participants