This repository has been archived by the owner on Jul 30, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 512
replace token loader with request loader to fix #81 #558
Merged
jirikuncar
merged 2 commits into
pallets-eco:develop
from
alanhamlett:replace-token-loader-with-request-loader
Apr 27, 2017
Merged
replace token loader with request loader to fix #81 #558
jirikuncar
merged 2 commits into
pallets-eco:develop
from
alanhamlett:replace-token-loader-with-request-loader
Apr 27, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flask-Security's dependency on Flask-Login is version-restricted. Can you update the versions with this change? |
Is something holding this up? |
Not that I know of, I think the maintainers forgot to merge it. |
For anyone else faced with this, put: Not ideal, but it will suffice until this is merged. |
@datashaman you can replace |
@jirikuncar thanks! |
Jirikuncar, thanks for the heads up! That saved me! |
Thanks @jirikuncar! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just moved some code around, but the main change is using
request_loader
on the login manager instead oftoken_loader
to fix #557.