-
Notifications
You must be signed in to change notification settings - Fork 845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typos in demo #288
Fix typos in demo #288
Conversation
Very minor typo/grammar corrections.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please respond to my comment if you want to have this change merged.
demo/demo.tex
Outdated
@@ -71,7 +71,7 @@ \section{Titleformats} | |||
This frame uses the \texttt{smallcaps} titleformat. | |||
|
|||
\begin{alertblock}{Potential Problems} | |||
Be aware, that not every font supports small caps. If for example you typeset your presentation with pdfTeX and the Computer Modern Sans Serif font, every text in smallcaps will be typeset with the Computer Modern Serif font instead. | |||
Be aware that not every font supports smallcaps. If for example you typeset your presentation with pdfTeX and the Computer Modern Sans Serif font, every text in smallcaps will be typeset with the Computer Modern Serif font instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I proposed the change not as an improvement to the descriptive meaning (which would indeed be better served with "small caps", like Wikipedia suggests), but as consistent naming across the demo slides.
As examples:
- Further in the same sentence, there is "... every text in smallcaps will be...".
- On the next slide in the demo, there is "... as with the \texttt{smallcaps} titleformat."
Perhaps a better change would then be to replace "small caps" with "\texttt{smallcaps}". I can edit my change accordingly if you agree.
P.S.: The same discussion can apply to "title format" vs. "titleformat", by the way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, okay, I see. Well, I think then we can fix it all along so it's consistent with small caps
and title format
in normal text and \texttt{smallcaps}
and \texttt{titleformat} if we refer to the actual command.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, it's likely the best way for consistency. I can push changes soon (= end of this week).
Use 'small caps' when mentioning it in normal text. Use '\texttt{smallcaps}' when referring to the command. Similarly for 'title format' and '\texttt{titleformat}'. N.B.: There are no instances of '\texttt{titleformat}'.
I have made changes to the text as discussed. There were no older instances of \texttt{titleformat}, and I did not find any situations where the command was explicitly meant, so consequently, there are no occurences of the command \texttt{titleformat} now. |
Thanks for the update! |
Very minor typo/grammar corrections.