-
Notifications
You must be signed in to change notification settings - Fork 844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Color themes #64
Color themes #64
Conversation
I'm sorry, but I do not get the point of this pull request. You already can easily create a custom color theme, where you just have to redefine the four used colors. Or you can even use the color themes provided by the beamer class itself. So why do you think it is useful to divide the color theme into more different files? On the other hand I think it is totally sufficient to provide only one color theme, as the requirements regarding color are probably very individual. But that's discussible. Maybe it does make sense to provide some more carefully chosen color themes, as the color themes provided from beamer itself look imho mostly awful. |
While I like the idea of easy color customization I think it should be done in a more semantic way (i.e. |
I think it does make sense to provide several color themes. Beamer color themes look awful, and it may be difficult for someone to find good colors. The "common" color theme is for code factorization. Without it, we would have to copy-paste its whole content in each color theme (and thus modify every copy each time you want to do a global modification of the color themes). About |
@matze Yes, to think about more universal names makes probably sense. Something like @Ezibenroc The thing is, you already do not need to copy-paste the whole color definition. So for example you can load the theme, redefine the colors and it just works.
Or you can obviously outsource the color redefinitions into a separate color theme file and just load that.
Stil there is no need to redefine everything. |
This reverts commit 1590ebc.
Ok, I did not think it could work like this. I applied your suggestion for the code and the color names. |
Yeah, sometimes TeX is easier than you think. ;) |
I think having some alternative color themes to the default one would be nice. While I like the current color theme, my main attraction to using metropolis was its minimalist design and use of a beautiful font. Being able to easily swap to a different color scheme would be a handy feature. I see there being three separate issues for integrating that:
Finally, if this feature moves forward and optional color themes are added, might I suggest extending to a naming system of fictional cities? For example, if we want to continue with comic books, |
Another remark. In the file
This should either be
or be removed completely. I personally think it is not really needed. There is no harm to load it twice, respectively it can even make sense to load it multiple times. If – for example – you want to change the color theme for one specific section and then revert that change for the next section, then it would be necessary to load the theme twice. The same is true for the |
I think an image with a sample frame and arrows pointing to the different colored elements could be an easy cheat sheet for the lazy ones.
I just checked and it's easily possible to redefine colors between frames, so we could either supply a themes.pdf or update the demo.pdf to showcase the different color themes.
That sounds like a great idea! Now, the question: is this going to be fleshed out in this PR or a separate one? |
Yes, EDIT: Forgot to check the progress bar.
Very good idea.
Although I like the idea using fictional cities as a naming system, it has its drawbacks, as you have no idea how the color theme looks like. |
I would recommend against using semantic colour names, because those semantics are already encapsulated by \definecolor{mLightBrown}{HTML}{EB811B}
\setbeamercolor{alerted text}{fg=mLightBrown} which a user can override with \setbeamercolor{alerted text}{fg=blue} I think this is clearer than renaming each colour to something unrelated to its appearance and asking users to redefine the colour. If the concern is about duplication of code, it may be possible to set all (or most) of the colours in terms of |
@rchurchley: Good point. As long as there's some sort of semantic hook for people to define, that should be pretty easy to use. What happens for something like this, though?
I currently use
While that's true, I don't think a title of |
@rchurchley I understand your reasoning. But the two approaches do not exclude each other. So maybe we should start with redefining everything using the @ChipmunkMath Ok I'm sorry. I have not tested the Regrading the color theme names: Ok lets have a bit of fun. Why not. ;) But then we can maybe think about providing color theme sample frames inside the README file to make it easy for the user to chose a color theme. |
Some further thoughts: I just played around a little bit trying to make all the code dependent on the four
Strictly using semantic color names (and a little bit of cleaning) the code would look like this
Much cleaner and easy to understand for everybody.
A beamer color always consists of a foreground and a background. Hence in my opinion the |
@benjamin-weiss I applied your remark about the Replacing |
@benjamin-weiss : It's possible to write much more readable and flexible code than the current blockbg definition: \setbeamercolor{block title alerted}{%
use={block title, alerted text},
bg=block title.bg,
fg=alerted text.fg
} In response to
A beamer colour can have a foreground and a background, but doesn't have to have both (see the \setbeamercolor{alerted text}{fg=mLightBrown}
\setbeamercolor{frametitle}{fg=white, bg=mDarkTeal} and I still prefer using descriptive names with This is all a bit abstract in theory, so I've implemented my suggestion as #66. |
I like the proposition of @rchurchley: it allows to easily change the background. This is not possible in this PR if we only modify the four top colors. |
Ok, you are right. There seemed to be some misunderstanding on my side.
That is more readable. Yet still I think beamer colors are somewhat annoying complicated.
Probably that was the original idea to define the color themes. Nevertheless even some of the build in color themes rely more on So we dismiss this PR and continue discussion on @rchurchley s PR #66? |
Yep. |
Related to #55.
A good beamer theme should provide several color themes, to fit the needs of its users.
This PR allow one to easily write a new color theme, thanks to code factorization: just set the four colors
mDarkTeal
,mDark
,mMedium
andmLight
.As an example, two color themes are provided:
metropolis
(the original theme), andblue
.Fill free to modify the colors I set for the
blue
theme, as my tastes are maybe not so good.It would be great to provide other color themes, based on this idea. At least one theme per main color.