Notify only on failure #72
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
We've been using your bot and we noticed that there were a lot of 429 errors in our logs.
It makes atleast 3 requests per job:
1 request to add a reaction to the push message to says that the job is creating
1 request to redact that redaction when a new state comes in
1 request to notify of the new state finished or failed
It can grows quite quickly, we have a pipeline with 15 jobs so maubot couldn't catch on, even with a retry the situation isn't ideal.
So with this PR I propose an option to only react to a message only when the job fails