Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add regex option for the include_tables and exclude_tables params #31

Merged
merged 3 commits into from
May 12, 2024

Conversation

dukkee
Copy link
Contributor

@dukkee dukkee commented Mar 31, 2024

Hey @maurerle I think it will be good to have an opportunity to pass regex to the table name filters

Copy link
Owner

@maurerle maurerle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thank you for this valuable pull request.

Could you also add tests to test_filter_exclude_tables?
Would also be good to have test cases of filters which do not match (like "par" alone without .*) and make sure they work correctly :)

eralchemy2/main.py Outdated Show resolved Hide resolved
eralchemy2/main.py Outdated Show resolved Hide resolved
@maurerle
Copy link
Owner

Hi @dukkee - any update on this?

@maurerle maurerle merged commit 3680ebf into maurerle:main May 12, 2024
5 checks passed
@dukkee
Copy link
Contributor Author

dukkee commented May 13, 2024

hey @maurerle I'm sorry for so late answer.. Thank you a lot for your help 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants