add cache docs #172
add cache docs #172
Conversation
| link_text = "Symfony Cache Component" | ||
| link_url = "https://symfony.com/doc/current/components/cache.html" | ||
|
|
||
| link.xref_links.update({link_name: (link_text, link_url)}) |
There was a problem hiding this comment.
These files are created automatically using the make link command, so I think we are OK to leave as they are :)
Co-authored-by: Ruth Cheesley <ruth@ruthcheesley.co.uk>
Co-authored-by: Rohit Joshi <joshi.rohit100@gmail.com>
|
@RCheesley I have gone through the comments; please check if this is good to go. Vale is throwing an error but it's highlighting words that are in the code block |
There was a problem hiding this comment.
Quite a lot of changes @fakela - please make sure you are working on these PRs using VSCode / Gitpod or at least running the linting in your IDE. Many of these were clearly flagged up as errors when I opened the PR in Gitpod.
The most common issues:
- Code blocks must have a single line break after the directive and before the code
- Code blocks must have a single line break after the code and before the following text
This should then fix some of the issues with the linter trying to parse the code blocks - because the markup wasn't correct it just sees them as regular text.
Would run it on Gitpod now |
Co-authored-by: Ruth Cheesley <ruth@ruthcheesley.co.uk>
Co-authored-by: Ruth Cheesley <ruth@ruthcheesley.co.uk>
Co-authored-by: Ruth Cheesley <ruth@ruthcheesley.co.uk>
Co-authored-by: Ruth Cheesley <ruth@ruthcheesley.co.uk>
Co-authored-by: Ruth Cheesley <ruth@ruthcheesley.co.uk>
Co-authored-by: Ruth Cheesley <ruth@ruthcheesley.co.uk>
Co-authored-by: Ruth Cheesley <ruth@ruthcheesley.co.uk>
Co-authored-by: Ruth Cheesley <ruth@ruthcheesley.co.uk>
Co-authored-by: Ruth Cheesley <ruth@ruthcheesley.co.uk>
Co-authored-by: Ruth Cheesley <ruth@ruthcheesley.co.uk>
Co-authored-by: Ruth Cheesley <ruth@ruthcheesley.co.uk>
Co-authored-by: Ruth Cheesley <ruth@ruthcheesley.co.uk>
Co-authored-by: Ruth Cheesley <ruth@ruthcheesley.co.uk>
Co-authored-by: Ruth Cheesley <ruth@ruthcheesley.co.uk>
|
All checks passed @RCheesley |
|
All good, just need developer review! @escopecz could you review? |
@RCheesley i have moved the cache docs to this PR: #148