Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the issue the loading spinner is always spinning #45

Merged
merged 2 commits into from
Jan 31, 2024
Merged

Fix the issue the loading spinner is always spinning #45

merged 2 commits into from
Jan 31, 2024

Conversation

volha-pivavarchyk
Copy link
Contributor

No description provided.

@volha-pivavarchyk volha-pivavarchyk mentioned this pull request Oct 4, 2023
Merged
mollux
mollux previously approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@mollux mollux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this fixes the save button (and some unrelated issues)

@mollux
Copy link
Contributor

mollux commented Oct 4, 2023

@volha-pivavarchyk we can merge this into the main branch I think? as it's not related to ckeditor5?

@mollux
Copy link
Contributor

mollux commented Oct 4, 2023

@volha-pivavarchyk I would commit the generated files for now, I don't see a workflow here that builds them

We can look into a better flow once M5 is released :)

@volha-pivavarchyk volha-pivavarchyk changed the base branch from ckeditor5 to main October 4, 2023 16:32
@volha-pivavarchyk volha-pivavarchyk dismissed mollux’s stale review October 4, 2023 16:32

The base branch was changed.

@volha-pivavarchyk
Copy link
Contributor Author

@mollux I added the dist files. Now I know that they should be added :)

I think it can be merged into main. I chose the checkeditor5 branch as this branch was used in PR #44.

@LordRembo LordRembo self-requested a review January 31, 2024 10:06
@LordRembo
Copy link
Contributor

LordRembo commented Jan 31, 2024 •
edited
Loading

  • Checked out the plugin,
  • copied it into Mautic's grapesjs builder bundle
  • rebuilt the bundle
  • saved an email
  • got a notification of successful save

notification-spinner

@mollux mollux changed the base branch from main to 5.x January 31, 2024 10:27
@mollux mollux merged commit b1ee678 into mautic:5.x Jan 31, 2024
@annamunk annamunk mentioned this pull request Feb 26, 2024
Closed
1 task
@annamunk annamunk mentioned this pull request Apr 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LordRembo LordRembo LordRembo approved these changes

@mollux mollux mollux approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@volha-pivavarchyk @mollux @LordRembo