Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jQuery UI update #12394

Merged
merged 2 commits into from May 26, 2023
Merged

jQuery UI update #12394

merged 2 commits into from May 26, 2023

Conversation

escopecz
Copy link
Sponsor Member

@escopecz escopecz commented May 26, 2023

Q A
Bug fix? (use the a.b branch) [library update]
New feature/enhancement? (use the a.x branch) [ ]
Deprecations? [ ]
BC breaks? (use the c.x branch) [ ]
Automated tests included? [ ]
Related user documentation PR URL mautic/mautic-documentation#...
Related developer documentation PR URL mautic/developer-documentation#...
Issue(s) addressed Fixes https://mautic.atlassian.net/browse/TPROD-433

Description:

This PR is updating jQuery UI from version 1.12.1 to 1.13.2 and replaces the hard-coded JS file with an NPM dependency. I went through the hard-coded 4.jquery-ui.js file and loaded the same parts of jQueryUI library as before.

Steps to test this PR:

  1. Open this PR on Gitpod or pull down for testing locally (see docs on testing PRs here)
  2. Check that the list of custom fields can be draggable to change field order.
  3. Also form fields or segment filters are draggable to change order but if it works in one place then it will work elsewhere too. But it won't hurt to confirm.
  4. Check that there are no JS errors in your browser's dev tools console

@escopecz escopecz added this to the 5.0-alpha milestone May 26, 2023
@escopecz escopecz added bug Issues or PR's relating to bugs ready-to-test PR's that are ready to test refactoring The change does not change behavior but improves the code labels May 26, 2023
@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Merging #12394 (17fea7b) into 5.x (f33c608) will increase coverage by 0.61%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                5.x   #12394      +/-   ##
============================================
+ Coverage     55.65%   56.27%   +0.61%     
+ Complexity    35661    35131     -530     
============================================
  Files          2243     2209      -34     
  Lines        106976   105431    -1545     
============================================
- Hits          59540    59327     -213     
+ Misses        47436    46104    -1332     
Impacted Files Coverage Δ
...undles/CoreBundle/Helper/AssetGenerationHelper.php 56.95% <ø> (ø)

... and 43 files with indirect coverage changes

Copy link
Member

@mabumusa1 mabumusa1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this PR, it works as expected custom fields are dragable, form and dashboard widgets

@escopecz escopecz merged commit 3448b15 into mautic:5.x May 26, 2023
11 checks passed
@escopecz escopecz deleted the jquery-ui-update branch May 29, 2023 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues or PR's relating to bugs ready-to-test PR's that are ready to test refactoring The change does not change behavior but improves the code
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants