Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make olm optional #17

Closed
rumpelsepp opened this issue Aug 7, 2020 · 4 comments
Closed

Make olm optional #17

rumpelsepp opened this issue Aug 7, 2020 · 4 comments

Comments

@rumpelsepp
Copy link

Since the olm stuff depends on C libraries, it would be nice if the c dep could be disabled with build tags.

@tulir
Copy link
Member

tulir commented Aug 7, 2020

It already is optional: the crypto module isn't imported from any other module

@rumpelsepp
Copy link
Author

Hmm, when I go get -u my project it complains:

$ go get -u ...
go: downloading maunium.net/go/mautrix v0.7.1-0.20200806170505-920619205aa2
# maunium.net/go/mautrix/crypto/olm
../../../go/pkg/mod/maunium.net/go/mautrix@v0.7.1-0.20200806170505-920619205aa2/crypto/olm/account.go:4:11: fatal error: olm/olm.h: No such file or directory
    4 | // #include <olm/olm.h>
      |           ^~~~~~~~~~~
compilation terminated

Any ideas? The code currently only does a login to a matrix server.

@tulir
Copy link
Member

tulir commented Aug 8, 2020

You probably shouldn't ... there. Just go build or go install should work

@rumpelsepp
Copy link
Author

rumpelsepp commented Aug 8, 2020

Probably. That's how I update the go dependencies along my projects. But it seems to work a bit too recursively…

@tulir tulir closed this as completed Sep 12, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

2 participants