Add context aware funcs for all existing api functions #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Contexts are good in general, not sure if there's any reason to duplicate all the functions instead of just adding a context parameter 🤔 There are lots of breaking changes anyway, the library is still v0.x |
|
I can definitely change the existing functions instead, I just didn't know if backwards compatibility was a priority. I'll update the PR to just change the existing functions since that is much cleaner. |
Doing so had pretty wide-spread effects, but at least context propagation is more or less everywhere
|
I updated the PR to change existing functions - that required quite a lot of other changes, but on the positive side context propagation is then everywhere |
recht
added a commit
to recht/mautrix
that referenced
this pull request
Dec 22, 2023
This should have been done in mautrix#144, but I forgot it. When context is being propagated, the context might be cancelled at any point, which will result in an error that needs to be handled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most functions didn't do this, which meant that timeouts, tracing, etc didn't work correctly.