Rename checkSignature to alwaysVerifyChecksum
#191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
longtimeago
approved these changes
Jun 8, 2021
There was a problem hiding this comment.
@kriegaex very nice! Thanks for the contribution 👍
Just tiny styling remarks
src/main/java/com/googlecode/download/maven/plugin/internal/checksum/Checksums.java
Outdated
Show resolved
Hide resolved
src/main/java/com/googlecode/download/maven/plugin/internal/checksum/Checksums.java
Outdated
Show resolved
Hide resolved
src/main/java/com/googlecode/download/maven/plugin/internal/checksum/Checksums.java
Outdated
Show resolved
Hide resolved
src/main/java/com/googlecode/download/maven/plugin/internal/checksum/Checksums.java
Outdated
Show resolved
Hide resolved
src/main/java/com/googlecode/download/maven/plugin/internal/checksum/Checksums.java
Outdated
Show resolved
Hide resolved
Fixes maven-download-plugin#186, see the naming and documentation discussion there. First, the plan was to just rename the one parameter and keep the one with the old name around as deprecated. while doing so, I noticed lots of - class and package names, - method names and parameters, - javadocs and comments, referring to digest-based checksums like SHA-1 and MD5 as "signatures" too, so I took care of globally renaming all of those too. That should make it easier to work with the code base in the future.
kriegaex
force-pushed
the
always-verify-checksum
branch
from
0072918
to
4380f22
Compare
longtimeago
approved these changes
Jun 8, 2021
kriegaex
added a commit
to kriegaex/aspectj
that referenced
this pull request
Sep 5, 2021
After my PR maven-download-plugin/maven-download-plugin#191 was merged and maven-download-plugin/maven-download-plugin#186 was closed, use a new release containing the option misnomer fix in order to make the POM more readable. Signed-off-by: Alexander Kriegisch <Alexander@Kriegisch.name>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #186, see the naming and documentation discussion there.
First, the plan was to just rename the one parameter and keep the one with the old name around as deprecated. while doing so, I noticed lots of
referring to digest-based checksums like SHA-1 and MD5 as "signatures" too, so I took care of globally renaming all of those too. That should make it easier to work with the code base in the future.
BTW, along the way I encountered the problem solved by #190, so maybe you want to merge than one first, if you like to run ITs on JDK 16 against this PR. Otherwise, the merge order does not matter.