Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use same version of coffeescript as bigmaven #1

Merged
merged 2 commits into from
Jul 2, 2019

Conversation

roblevintennis
Copy link

No description provided.

@roblevintennis roblevintennis self-assigned this Jul 1, 2019
@roblevintennis
Copy link
Author

roblevintennis commented Jul 1, 2019

I could not get the unit tests to run. I tried:
npm install -g nodeunit
npm install -g nodeunit@0.9.0 (per https://github.com/conversation/ShareJS/pull/16/files#diff-04c6e90faac2675aa89e2176d2eec7d8R51) but it wouldn't install.

For global nodeunit installation I had tried nodeunit test and cake test etc. etc. but was not able to get them to run. I'd be curious if anyone has done so in last few years ;)

If either of you knows how to run the suite I will, but otherwise onwards

Copy link

@naganowl naganowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a logical change so as long as npm install is successful this is good.

An additional check would be to point to this branch and observe that the test suite is green before merging this in.

@@ -14,7 +14,7 @@
}
, "dependencies":
{ "strscan": ">=1.0.1"
, "coffee-script": ">=1.2.0"
, "coffeescript": "^1.12.7"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that this matches what we've been using, this should be good!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Alan. Re

An additional check would be to point to this branch and observe that the test suite is green before merging this in.

I think that's a great idea Alan, and we'll need a PR to update our reference back anyway, so doing that should give us more confidence: https://github.com/mavenlink/mavenlink/pull/16795

I'm assuming this will go like:

  1. Ensure that bigmaven goes green
  2. Merge this
  3. Point back to eco#master from bigmaven, re-run yarn install and check in the update
  4. Ensure that again goes green
  5. Merge that in to bigmaven

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, just like if this were a mavenlink-js change!

@@ -2,7 +2,7 @@
(function() {
var CoffeeScript, indent, precompile, preprocess;

CoffeeScript = require("coffee-script");
CoffeeScript = require("coffeescript");
Copy link
Author

@roblevintennis roblevintennis Jul 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was led to doing all this from seeing the CI issue off bigmaven which as you can see points back to this compiler.js script

image

@roblevintennis
Copy link
Author

Ok, since https://github.com/mavenlink/mavenlink/pull/16795 is CI green, I think we're all good. Merging.

@roblevintennis roblevintennis merged commit 3ab97a1 into master Jul 2, 2019
@roblevintennis roblevintennis deleted the coffeescript-normalize-with-bigmaven branch July 2, 2019 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants