log_streaming: make it robust to message drops #2290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a message is dropped, we need to discard any message part. Otherwise, we end up having corrrupt ulog files. Signed-off-by: Julian Oes <julian@oes.ch>
|
|
@bkueng would be great if you could check I got this right. |
|
I believe this is better than what's in main, so I'm merging it now before the next release. |
bkueng
reviewed
May 13, 2024
Comment on lines
+305
to
+308
| _ulog_data.insert( | ||
| _ulog_data.end(), | ||
| logging_data_acked.data + logging_data_acked.first_message_offset, | ||
| logging_data_acked.data + logging_data_acked.length); |
There was a problem hiding this comment.
Here you must only insert if there's a valid offset: logging_data_acked.first_message_offset != std::numeric_limits<uint8_t>::max()
| switch (drop_state) { | ||
| case DropState::Ok: | ||
| if (logging_data_acked.first_message_offset == std::numeric_limits<uint8_t>::max()) { | ||
| _ulog_data.insert( |
There was a problem hiding this comment.
After a dropout you must first wait for a valid logging_data_acked.first_message_offset before inserting in _ulog_data
There was a problem hiding this comment.
I see. So I need to keep track of the previous state. Or rather set if there was a valid one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a message is dropped, we need to discard any message part. Otherwise, we end up having corrrupt ulog files.