Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add arm64-lts docker workflow #2304

Merged
merged 2 commits into from
May 27, 2024
Merged

Conversation

AlexKlimaj
Copy link
Contributor

This is an attempt to add an arm64-lts target which is needed on Jetson Jetpack 5.

@JonasVautherin
Copy link
Collaborator

Let's see what the CI says 😊

@julianoes
Copy link
Collaborator

julianoes commented May 18, 2024

I usually run this docker script manually and do the push, so that would explain the failure here.

I'll run it asap.

@julianoes
Copy link
Collaborator

Built and pushed. Now I'm re-running the failed jobs.

@AlexKlimaj have you thought about the naming of the LTS one? Should it be called debian 11 or something instead? We'll have to see what happens I suppose.

@AlexKlimaj
Copy link
Contributor Author

Hm I don't know what the best name for it should be.

@julianoes
Copy link
Collaborator

julianoes commented May 19, 2024

It looks like right now it is debian12-arm64-lts but that doesn't make much sense, I'd say we rename it to debian11 manually because it should be compatible with that.

Copy link

sonarcloud bot commented May 26, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
2 Security Hotspots
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@julianoes julianoes merged commit 572d28d into mavlink:main May 27, 2024
27 of 29 checks passed
@julianoes
Copy link
Collaborator

@AlexKlimaj AlexKlimaj deleted the pr-arm64-lts branch June 4, 2024 21:19
@AlexKlimaj
Copy link
Contributor Author

AlexKlimaj commented Jun 4, 2024

Hm, installed the debian11 release, our logloader code builds. But then the program segfaults when trying to run it.

jetson@jetson:~/code/logloader$ ./build/logloader
Segmentation fault (core dumped)

But building MAVSDK from source on the device works.

@julianoes
Copy link
Collaborator

Check with gdb where it segfaults. I bet it's std::filesystem::path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants