core: get rid of termios2, use termios on Linux #700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to simplify and to enable the build in manylinux1 it makes sense to go back to termios instead of termios2.
julianoes
force-pushed
the
remove-termios2
branch
from
ea4a37c
to
e762058
Compare
|
Do we lose something by doing that? e.g. the ability to use non-standard baudrates? |
|
I don't think so. |
julianoes
force-pushed
the
remove-termios2
branch
from
e762058
to
0eb13fe
Compare
|
Tested this on Linux and baudrate change doesn't seem to be working anymore. Needs more investigation. |
This includes the following baudrate fixes: - Checks to see if the baudrate could actually be set as expected. - Use baudrate defines instead of straight int, otherwise this doesn't work on Linux. - Add error code for the case of an unknown/unsupported baudrate.
The assumption is that we don't need to use the defines on macOS.
|
Tested on Linux and macOS, now works for both. |
JonasVautherin
approved these changes
Mar 20, 2019
Seems to me like it is failing on appveyor, and only in Debug, because of an unrelated curl test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to simplify and to enable the build in manylinux1 it makes sense to go back to termios instead of termios2.