Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gimbal_v2.md: Add clarification about gimbal yaw frame #531

Merged
merged 3 commits into from
Mar 15, 2024

Conversation

Davidsastresas
Copy link
Member

@Davidsastresas Davidsastresas commented Mar 13, 2024

Following the discussion here: mavlink/mavlink#2093 (comment)

@julianoes @hamishwillee let me know if it looks good to you. Thanks!

@hamishwillee
Copy link
Collaborator

Thanks very much @Davidsastresas . I've subedited to present this as "what you do first" and provide a little more context. Can you please check it still says what you want? @julianoes setting you as reviewer.

FYI also created mavlink/mavlink#2094 so there is some info in the message itself.

en/services/gimbal_v2.md Outdated Show resolved Hide resolved
Co-authored-by: Julian Oes <julian@oes.ch>
@hamishwillee hamishwillee merged commit 7c1b058 into mavlink:master Mar 15, 2024
@Davidsastresas
Copy link
Member Author

It is great, thank you @hamishwillee!

@rmackay9
Copy link

Sorry to be late to the party but I think we might want to clarify that for cases where the gimbal is providing the two new flags (GIMBAL_DEVICE_FLAGS_YAW_IN_VEHICLE_FRAME and GIMBAL_DEVICE_FLAGS_YAW_IN_EARTH_FRAME) we are still using the older GIMBAL_DEVICE_FLAGS_YAW_LOCK flag but now it is only used to hold the target (angle or rate) yaw frame.

So the new flags give the frame of the yaw angles and rates included in the GIMBAL_DEVICE_ATTITUDE_STATUS message. The GIMBAL_DEVICE_FLAGS_YAW_LOCK flag now says whether the GCS, user, whatever provided target yaw angles or rates in body-frame (aka follow) or earth-frame (aka lock).

@julianoes
Copy link
Contributor

Correct @rmackay9

@hamishwillee
Copy link
Collaborator

Thanks @rmackay9 - Attempted to clarify in #532

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants