GIMBAL_DEVICE_FLAGS_YAW* replace the lock #2094
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianoes
reviewed
Mar 15, 2024
|
@julianoes Can you edit it to capture the point then? Or should I just close this? |
|
It certainly can't be marked deprecated because it's still used. |
|
So maybe we can only comment in there that the preferred method is using the other flags. But as we have it in the docs, I don't see completely wrong the mavlink description as it is now either. |
|
Thanks! Closing this as unnecessary - the gimbal device status message itself captures the important parts, and as you say the flag is not deprecated in all cases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
GIMBAL_DEVICE_FLAGS_YAW_LOCKis retained for backwards compatibility. This is captured in mavlink/mavlink-devguide#531 but perhaps here as well @Davidsastresas @julianoes ?