-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new message radio_status_extensions in development #1748
new message radio_status_extensions in development #1748
Conversation
Thanks @leonardosimovic - is this abstract or do you have a particular radio and ground station in mind? I ask because we require a prototype before we push this into common.xml @julianoes @auturgy You guys know much about radios? |
how do i know what radio? |
@LorenzMeier brought up the question whether this message should also include a |
Apparently the RADIO_STATUS message is a bit weird. As I understand it the message is injected by a radio into the stream. It doesn't have an ID, and I am not sure how it is supposed to be used. @auturgy @julianoes Do you know the detail of how this part of the protocol is supposed to work - will better inform comments? Either way though, an IP radio is probably quite different, and might need different semantics. "generally" speaking if a system might have multiple radios and channels that we want to do something with, we're going to need to identify them individually. This set of data in the message seems reasonable but might not be exhaustive:
In summary, we don't know enough yet to assess this. |
great, I would have had to raise a related issue in the near future too (as I'm working on a lora mavlink link), so great :)
yes, it is injected on both sides, that is, the tx side sends it to the GCS and the rx side to the FC it does have an ID: https://mavlink.io/en/messages/common.html#MAV_COMP_ID_TELEMETRY_RADIO it is weird in the sense that it has an id but is not supposed to send heartbeats (that's at least how the SiK's work, and I would thus speculate that other's do too)
yes, PLEASE !! I do have in mind a true diversity system, so one would need the fields twice for each side, i.e., four times if one wants to stick with the xxx and remxxx pattern. I personally would have preferred one message, where the values for the 2nd could e.g. be extensions, and not all field values would really need to be doubled. But any solution is fine.
the cumulative fields like rxerrors or fixed etc are IMHO pretty useless |
Thanks for the feedback everyone! @hamishwillee The message was developed with a Silvus StreamCaster 4000 radio in mind but eventually it ought to be abstract. We first considered to extend the existing RADIO_STATUS message. However as @olliw42 mentioned, it is a bit of a special case because the message is implemented in the radios themselves. E.g. the SiK radios inject the message directly into the message stream and updating would be cumbersome. Hence we decided to use a second message for now. @olliw42 Could you explain what you mean by LQ?
Instead of repeating the fields we may also consider repeating the entire message. To do so we could define the local_radio_ID and remote_radio_ID to uniquely identify the stream. Suggested fields atm:
cc @mrivi |
LQ = link quality
I actually do not agree, I like that concept. It's kind of the easiest to do for a tx or rx.
I understand the point, but I'm also not a fan of these super huge messages which carry all sorts of fields of which only at most a handful are used, and which in addition need to be send multiplied ... I "hate" that waste of bandwidth and spilling of the network. IMHO |
Thanks all. @olliw42 Interesting. I guess you don't need a heartbeat since you don't need the message routed. I think the only other case of that is the HIGH_LATENCY. @leonardosimovic Thanks for the additional information. I think you're probably right not to extend the original RADIO_STATUS. What sort of rate would this be sent at, and what are the typical data rates we can expect from Silvus, microhard, and any other radio systems that might need this? @julianoes is there anyone in the dev team or Auterion with a lot of radio experience we can drag in to help arbitrate? I expect Daniele will have played with both Silvus and Microhard, and probably others? @auturgy You've played with a few too right? I have zero expertise on this. |
@hamishwillee that would be @eyeam3 |
I don't want to dive deeply into the pro and cons, since it's just a fact that this how the SiK's work. concerning the routing, that's actually some muddy territory, since not all routers appear to work the same. Some may route only when they have seen a respective heartbeat before, some others may route whenever they have seen an id in whatever message. (I think ardupilot is of the first kind, and mavlink-router of the second). The wording of the standard (https://mavlink.io/en/guide/routing.html) seems to imply the second kind. That is, if it is a router of the second kind then the RADIO_STATUS messages would be routed, and if one wants to take the standard as reference then they should be routed. Routers of the first kind appear to have special handling for the RADIO_STATUS message, which however can actually be of the kind to never forwad radio messages ;) (see https://github.com/ArduPilot/ardupilot/blob/master/libraries/GCS_MAVLink/MAVLink_routing.cpp#L108-L112) |
@olliw42 Thanks, and fair enough. I do not know the original intent but I interpret the standard in the same way. I don't want to get into the detail either :-) |
@hamishwillee yes, played with a few. If we're looking at Streamcaster, should probably consider MPU5 and TrellisWare too, as equivalent datalinks. DoodleLabs is also gaining traction. |
We are looking into how the message generalises with other radios and we'll update the pr accordingly |
@mrivi Any ETA on when you'll update this proposal? |
Hey @hamishwillee, unfortunately we didn't have the time to look into it yet but you can expect to hear from us within the first two weeks of January. Until then, happy holidays! |
Thanks for letting me know @leonardosimovic. Hope you guys have a great holiday too. |
reading this it occurs to me that one probably shouldn't consider such a message or message set to be "extensions" of the old radio_status message ... while certainly impressive and very cool, it appears that this is rather specialized and probably not of relevance to the larger userbase of older-style radio links |
@leonardosimovic Thanks for this. Just back from holidays. As previously, I personally don't have have domain knowledge to assess this. @auturgy @julianoes @lorenz - need technical assessment. Generally
Let's see what the information breakdown is before we decide on a final name(s). |
Closing this due to inactivity |
The RADIO_STATUS message contains the RSSI, however digital radios often provide additional information on the link status such as:
which can be useful when performing e.g. range tests.
Example data: