Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add radius to DO_REPOSITION #1787

Closed

Conversation

magicrub
Copy link
Contributor

Add Radius to CMD_DO_REPOSIITON for better atomic operations of control on guided commands. It uses language from the other CMD_NAV_LOITER commands.

Here's the same commit in a ArduPilot/mavlink PR: ArduPilot#240

I've discussed this with @WickedShell who's in favor of it.

@magicrub magicrub force-pushed the do_reposition_radius_upstream branch from a00e1ac to 3df61de Compare January 22, 2022 01:34
@magicrub
Copy link
Contributor Author

I'm having second thoughts about this. Would probably be better to just use a new enum entry in MAV_DO_REPOSITION_FLAGS to say radius is included and overrides the yaw value for planes

@WickedShell
Copy link
Collaborator

Either way works for me...

@magicrub
Copy link
Contributor Author

I'll re-work it so there's a new enum flag to re-purpose the yaw field for fixed-wing forward-moving vehicles

@hamishwillee
Copy link
Collaborator

I understand the purpose of radius, but not clear to me what you expect this MAV_DO_REPOSITION_FLAGS update to do. I.e. I see this as yaw (mc) or rotation direction (fw), but what value making the flag change has eludes me.

@hamishwillee
Copy link
Collaborator

@magicrub I'm closing this as "stale". You're welcome to reopen with work proposed in #1787 (comment) and answers to #1787 (comment)

@magicrub
Copy link
Contributor Author

@hamishwillee I've pushed changes, please re-open.

@hamishwillee
Copy link
Collaborator

@magicrub I'm sorry, but it won't let me because it has been force pushed. I have no idea why that is "not allowed", but I don't have the rights to reopen. You might have to push to a new branch and recreate/cross link this. Sorry.

@magicrub
Copy link
Contributor Author

magicrub commented Apr 8, 2022

replaced by #1825

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants